VR: apply iptables rules when add/remove static routes

[weizhouapache]

Description

Some iptables rules are created for static routes and private gateways since #6153
However, when add/remove static routes, the rules are not updated.

• Create a VPC and tier/vm
• Enable static nat to the vm
• Create private gateway
• Add static route to the private gateway

check the iptables rules by iptables-save |grep PREROUTING-eth1-def
expected: there is a rule for the static route, for example 192.168.x.x/24

-A PREROUTING-eth1-def -d 192.168.x.x/24 -j RETURN

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.12%. Comparing base (971a5b2) to head (b4e20fd).
Report is 11 commits behind head on 4.19.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10064   +/-   ##
=========================================
  Coverage     15.12%   15.12%           
- Complexity    11259    11262    +3     
=========================================
  Files          5408     5408           
  Lines        473842   473842           
  Branches      57771    57771           
=========================================
+ Hits          71677    71688   +11     
+ Misses       394168   394155   -13     
- Partials       7997     7999    +2     

Flag	Coverage Δ
uitests	4.30% <ø> (ø)
unittests	15.84% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[DaanHoogland]

clgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11758

[DaanHoogland]

@blueorangutan test keepEnv

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11871)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51595 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10064-t11871-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

tested, without static nat:

and with static nat:

[vishesh92]

lgtm