UI: fix cannot open 'Edit tags' modal for static routes #10065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10065 +/- ##
============================================
- Coverage 15.12% 15.12% -0.01%
+ Complexity 11259 11258 -1
============================================
Files 5408 5408
Lines 473842 473841 -1
Branches 57771 57771
============================================
- Hits 71677 71676 -1
Misses 394168 394168
Partials 7997 7997
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
shwstppr
approved these changes
Dec 26, 2024
Contributor
shwstppr
left a comment
shwstppr
left a comment
There was a problem hiding this comment.
LGTM. We don't have rulesRef in this view
shwstppr
approved these changes
Dec 26, 2024
Contributor
shwstppr
left a comment
shwstppr
left a comment
There was a problem hiding this comment.
Tested on QA server
Before
After
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue that "Edit tags" dialog cannot be opened for static routes.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?