Static Routes: fix check on wrong global configuration

[weizhouapache]

Description

This PR fixes the wrong checks on CIDR of static routes

• define global/zone configuration denied.routes, which has already added to database some years ago
  

  cloudstack/engine/schema/src/main/resources/META-INF/db/schema-41520to41600.sql

  Lines 586 to 587 in c94d0ab

  	-- Update name for global configuration 'blacklisted.routes' to 'denied.routes'
  	UPDATE `cloud`.`configuration` SET name='denied.routes', description='Routes that are denied, can not be used for Static Routes creation for the VPC Private Gateway' WHERE name='blacklisted.routes';

• check on the configuration denied.routes ,instead of GuestDomainSuffix

• check if the route cidr (instead of vpc cidr) is link-local

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (971a5b2) to head (8df2245).
Report is 55 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/network/vpc/VpcManagerImpl.java	0.00%	2 Missing ⚠️
...tack/engine/orchestration/NetworkOrchestrator.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10066      +/-   ##
============================================
- Coverage     15.12%   15.12%   -0.01%     
+ Complexity    11259    11258       -1     
============================================
  Files          5408     5408              
  Lines        473842   473843       +1     
  Branches      57771    57771              
============================================
- Hits          71677    71676       -1     
- Misses       394168   394169       +1     
- Partials       7997     7998       +1     

Flag	Coverage Δ
uitests	4.30% <ø> (ø)
unittests	15.84% <25.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

clgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11759

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11872)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55319 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10066-t11872-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_secured_to_nonsecured_vm_migration	Error	397.10	test_vm_life_cycle.py

[shwstppr]

Code lgtm

[DaanHoogland]

tested in lab environment, after setting denied.routes to 10.100.0.0/16,