Skip to content

Conversation

@Rubueno
Copy link
Contributor

@Rubueno Rubueno commented Dec 13, 2024

Description

This PR fixes a typo

Types of changes

  • Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

No testing required for a typo fix.

How did you try to break this feature and the system with this change?

N/A

Copy link
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@DaanHoogland
Copy link
Contributor

config key description only, let's wait for github actions and merge

@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.90%. Comparing base (91ab67c) to head (77d6d2c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10104      +/-   ##
============================================
+ Coverage     16.06%   16.90%   +0.84%     
  Complexity    12864    12864              
============================================
  Files          5642     5248     -394     
  Lines        493856   461495   -32361     
  Branches      59860    54147    -5713     
============================================
- Hits          79326    78023    -1303     
+ Misses       405749   374838   -30911     
+ Partials       8781     8634     -147     
Flag Coverage Δ
uitests ?
unittests 16.90% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Contributor

UI build error is unrelated (annoying though.

@DaanHoogland DaanHoogland merged commit 54bc150 into apache:main Dec 14, 2024
24 of 25 checks passed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants