Primera pure patches & various small fixes

[rg9975]

Description

This PR...
This PR fixes several small issues with Fiberchannel implementation and locally discovered issues:

1. volume disconnect timing issues
2. rescan cleanup script not working correctly
3. template copy issues
4. masked/hidden errors and exceptions

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested locally with real world workloads

How did you try to break this feature and the system with this change?

Tested locally with real world workloads

[slavkap]

@DaanHoogland, unfortunately, I don't have time now to test this but the code LGTM

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12232

[rp-]

I'll run this patch against a Linstor cluster to see if it breaks anything.

[DaanHoogland]

is there consensus growing on this or shall I move this to 4.19.3 and up?

[rg9975]

@DaanHoogland I'd like to review @rp- comments today, just could not get to it yesterday. Will provide comments/updates later today.

[DaanHoogland]

@rp- can you review the last changes.

[rp-]

@rp- can you review the last changes.

@DaanHoogland @rg9975

So I dug a bit deeper and found the actual problem to be the cloud-install-sys-tmplt script.
I use it in my automated CloudStack installations and this scripts sets size and physical_size 0 in the template_store_ref table, which than Linstor can't use to create a template.

If I don't use the script at all, and let CloudStack fetch the template on its own, the entries are correct and the Linstor driver already creates the volume on management server and everything is fine.

So my question is, is this script still recommended for installation? And if so can we fix it?

[DaanHoogland]

@rp- can you review the last changes.

@DaanHoogland @rg9975

So I dug a bit deeper and found the actual problem to be the cloud-install-sys-tmplt script. I use it in my automated CloudStack installations and this scripts sets size and physical_size 0 in the template_store_ref table, which than Linstor can't use to create a template.

If I don't use the script at all, and let CloudStack fetch the template on its own, the entries are correct and the Linstor driver already creates the volume on management server and everything is fine.

So my question is, is this script still recommended for installation? And if so can we fix it?

because ACS packages no (can) include the template the script has somewhat gotten out of use. It should still work, but I am not sure how to fix it.

[rp-]

@rp- can you review the last changes.

@DaanHoogland @rg9975
So I dug a bit deeper and found the actual problem to be the cloud-install-sys-tmplt script. I use it in my automated CloudStack installations and this scripts sets size and physical_size 0 in the template_store_ref table, which than Linstor can't use to create a template.
If I don't use the script at all, and let CloudStack fetch the template on its own, the entries are correct and the Linstor driver already creates the volume on management server and everything is fine.
So my question is, is this script still recommended for installation? And if so can we fix it?

because ACS packages no (can) include the template the script has somewhat gotten out of use. It should still work, but I am not sure how to fix it.

AFAIS the script already gets the sizes and writes them correctly into the template.properties file, so all it would need to do is also update the database entries too?

[DaanHoogland]

AFAIS the script already gets the sizes and writes them correctly into the template.properties file, so all it would need to do is also update the database entries too?

sounds good, does that mean we can merge this, @rp- ?

[rp-]

AFAIS the script already gets the sizes and writes them correctly into the template.properties file, so all it would need to do is also update the database entries too?

sounds good, does that mean we can merge this, @rp- ?

well, we can revert/drop then that last commit: f066100

[rg9975]

I've reverted commit #f066100

AFAIS the script already gets the sizes and writes them correctly into the template.properties file, so all it would need to do is also update the database entries too?

sounds good, does that mean we can merge this, @rp- ?

well, we can revert/drop then that last commit: [f066100]

Reverted.

[DaanHoogland]

@rp- , can you approve??

[rp-]

Just to have it noted here, I'll probably create an issue out of it.
It isn't the cloud-install-sys-tmplt script (maybe its usage), but the actual problem is in:

cloudstack/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java

Line 1242 in cd81398

tmpltStore.setPhysicalSize(0); // no size information for

For pre-seeded templates, the template_store_ref entries get pre filled with 0 and never updated, which is bad I guess for most primary storages.
Using preseeded templates and this commit will break using those templates, until the DB entries are fixed.

[DaanHoogland]

Just to have it noted here, I'll probably create an issue out of it. It isn't the cloud-install-sys-tmplt script (maybe its usage), but the actual problem is in:

cloudstack/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java

Line 1242 in cd81398

tmpltStore.setPhysicalSize(0); // no size information for

For pre-seeded templates, the template_store_ref entries get pre filled with 0 and never updated, which is bad I guess for most primary storages. Using preseeded templates and this commit will break using those templates, until the DB entries are fixed.

ok, that to me sounds like we shouldn't merge this untill we fix that as well.

[rp-]

Just to have it noted here, I'll probably create an issue out of it. It isn't the cloud-install-sys-tmplt script (maybe its usage), but the actual problem is in:

cloudstack/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java

Line 1242 in cd81398

tmpltStore.setPhysicalSize(0); // no size information for

For pre-seeded templates, the template_store_ref entries get pre filled with 0 and never updated, which is bad I guess for most primary storages. Using preseeded templates and this commit will break using those templates, until the DB entries are fixed.

ok, that to me sounds like we shouldn't merge this untill we fix that as well.

I have worked out a possible fix #10317

[DaanHoogland]

I have worked out a possible fix #10317

will regression test #10317 and merge it together with this.