Skip to content

[UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume #10265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 5 commits into from
May 2, 2025
Merged

[UI] Allow quiescevm and asyncbackup flags while taking volume snapshot from UI when these are supported for the volume #10265

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ead3b5f
[UI] Allow quiescevm and asyncbackup flags while taking volume snapsh…
sureshanaparti Jan 24, 2025
f1c1568
quiescevm false when not set
sureshanaparti Apr 21, 2025
9675df5
update payload with quiescevm when set for vm snapshot
sureshanaparti Apr 21, 2025
57126b7
keep quiescevm for supported hypervisors (VMware, KVM) in ui
sureshanaparti Apr 21, 2025
f2f2c7b
unit test fix
sureshanaparti Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/views/compute/CreateSnapshotWizard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
</template>
<a-switch v-model:checked="form.quiescevm"/>
</a-form-item>
<a-form-item name="asyncbackup" ref="asyncbackup">
<a-form-item name="asyncbackup" ref="asyncbackup" v-if="!supportsStorageSnapshot">
<template #label>
<tooltip-label :title="$t('label.asyncbackup')" :tooltip="apiParams.asyncbackup.description"/>
</template>
Expand Down
4 changes: 2 additions & 2 deletions ui/src/views/storage/TakeSnapshot.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@
</a-select-option>
</a-select>
</a-form-item>
<a-form-item :label="$t('label.asyncbackup')" name="asyncbackup" ref="asyncbackup">
<a-form-item :label="$t('label.asyncbackup')" name="asyncbackup" ref="asyncbackup" v-if="!supportsStorageSnapshot">
<a-switch v-model:checked="form.asyncbackup" />
</a-form-item>
<a-form-item :label="$t('label.quiescevm')">
<a-form-item :label="$t('label.quiescevm')" name="quiescevm" ref="quiescevm" v-if="quiescevm">
<a-switch v-model:checked="form.quiescevm" />
</a-form-item>
<a-divider/>
Expand Down
Loading