Revert #10240

[DaanHoogland]

Reverts #10240
"Improve listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag"

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (0d5047b) to head (53573c1).
Report is 3 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/host/dao/HostDaoImpl.java	0.00%	29 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10314   +/-   ##
=========================================
  Coverage     15.16%   15.16%           
- Complexity    11300    11303    +3     
=========================================
  Files          5408     5408           
  Lines        473912   473901   -11     
  Branches      57844    57841    -3     
=========================================
+ Hits          71855    71871   +16     
+ Misses       394025   393997   -28     
- Partials       8032     8033    +1     

Flag	Coverage Δ
uitests	4.29% <ø> (ø)
unittests	15.89% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

[weizhouapache]

@blueorangutan test

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12304

[JoaoJandre]

Why is #10240 being reverted? Shouldn't there be an explanation for reverting a PR?

[DaanHoogland]

Why is #10240 being reverted? Shouldn't there be an explanation for reverting a PR?

it is to test a set of failures @JoaoJandre if we proceed there will of course be some discourse. Notice that several 4.19 PR have excessive failures and we don't know why, but as 10240 was merged without smoke tests it is a suspect. we are still investigating.

Sorry for the lack of communication.

[blueorangutan]

[SF] Trillian test result (tid-12276)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48386 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10314-t12276-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_12_start_vm_multiple_volumes_allocated	Error	13.33	test_vm_life_cycle.py

[DaanHoogland]

Why is #10240 being reverted? Shouldn't there be an explanation for reverting a PR?

it is to test a set of failures @JoaoJandre if we proceed there will of course be some discourse. Notice that several 4.19 PR have excessive failures and we don't know why, but as 10240 was merged without smoke tests it is a suspect. we are still investigating.

Sorry for the lack of communication.

false alarm as we found on #10240 , so closing this one.