UI: Add VM state to Volume list view #10341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10341 +/- ##
============================================
+ Coverage 16.02% 16.08% +0.05%
- Complexity 13148 13175 +27
============================================
Files 5658 5659 +1
Lines 496312 496858 +546
Branches 60109 60169 +60
============================================
+ Hits 79538 79922 +384
- Misses 407925 407997 +72
- Partials 8849 8939 +90
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
reviewed
Feb 7, 2025
DaanHoogland
approved these changes
Feb 7, 2025
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
not caring about language so much; clgtm and tested in QA (stopped a vm to check the right state)
JoaoJandre
reviewed
Feb 7, 2025
rohityadavcloud
approved these changes
Feb 11, 2025
JoaoJandre
approved these changes
Feb 12, 2025
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 19, 2025
* Add vm state to volume list view * Change size column order --------- Co-authored-by: Lucas Martins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new column to the volume list view that shows the state of the VM the volume is attached to.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
In a local environment, I attached a volume to a VM and changed the VM state multiple times. As expected, the current state of the VM was shown in the volume list view.