Skip to content

Conversation

@bernardodemarco
Copy link
Member

Description

In the Public IP Addresses UI section, the options to release reserved IPs (releaseIpAddress API) and disassociate IPs (disassociateIpAddress API) are always available through group actions, regardless of the public IP's state. Additionally, the option to disassociate IPs is available for IPs in use by system VMs, both through group actions and dataView.

This PR fixes these UI bugs. Furthermore, a label, similar to the existing ones for source-nat and static-nat, was created to indicate that a public IP is in use by a system VM. Lastly, the allocated column in the ListView, that represents the datetime an IP was allocated, is now parsed and formatted according to the user's timezone.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

  • disassociateIpAddress through group actions:
    image
  • releaseIpAddress through group actions:
    image

How Has This Been Tested?

  • Created a VPC (vpc-01) and acquired two additional public IPs;
  • Accessed the Public IP Addresses UI section and verified that the public IPs in use by the system VMs were marked with the system tag;
  • Verified that the allocated datetime was correctly parsed and formatted according to the timezone in use;
  • Verified that:
    • the options to disassociate and release system IPs were not available through group actions or dataView;
    • the options to disassociate and release source-nat IPs were not available through group actions or dataView;
    • the option to disassociate an allocated IP was available through group actions;
    • the option to release IP addresses was available for Reserved IPs.

@bernardodemarco
Copy link
Member Author

@blueorangutan ui

@bernardodemarco bernardodemarco added this to the 4.19.3 milestone Feb 8, 2025
@blueorangutan
Copy link

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.15%. Comparing base (a1117ac) to head (489c3ad).
Report is 18 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #10351      +/-   ##
============================================
- Coverage     15.15%   15.15%   -0.01%     
+ Complexity    11314    11313       -1     
============================================
  Files          5409     5409              
  Lines        474756   474758       +2     
  Branches      57926    57926              
============================================
- Hits          71943    71938       -5     
- Misses       394767   394774       +7     
  Partials       8046     8046              
Flag Coverage Δ
uitests 4.29% <ø> (-0.01%) ⬇️
unittests 15.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10351 (QA-JID-546)

@julien-vaz
Copy link
Contributor

julien-vaz commented Feb 24, 2025

Through the Live QA URL provided by blueorangutan, I've repeated the tests described in the PR description and confirmed that the bugs were fixed. The tags show up correctly, the user can no longer disassociate or release a source-nat or system IP and the release option for Reserved IP is available.

Copy link
Contributor

@julien-vaz julien-vaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Therefore, I approve this PR.

@DaanHoogland DaanHoogland merged commit a09c579 into apache:4.19 Feb 26, 2025
25 checks passed
@Pearl1594 Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
dhslove added a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants