-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: Fixes and minor enhacements to the Public IP Addresses section #10351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10351 +/- ##
============================================
- Coverage 15.15% 15.15% -0.01%
+ Complexity 11314 11313 -1
============================================
Files 5409 5409
Lines 474756 474758 +2
Branches 57926 57926
============================================
- Hits 71943 71938 -5
- Misses 394767 394774 +7
Partials 8046 8046
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
|
Through the Live QA URL provided by blueorangutan, I've repeated the tests described in the PR description and confirmed that the bugs were fixed. The tags show up correctly, the user can no longer disassociate or release a |
julien-vaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Therefore, I approve this PR.
…ction (apache#10351)" This reverts commit f3b2c9c.
Description
In the Public IP Addresses UI section, the options to release reserved IPs (
releaseIpAddressAPI) and disassociate IPs (disassociateIpAddressAPI) are always available through group actions, regardless of the public IP's state. Additionally, the option to disassociate IPs is available for IPs in use by system VMs, both through group actions anddataView.This PR fixes these UI bugs. Furthermore, a label, similar to the existing ones for
source-natandstatic-nat, was created to indicate that a public IP is in use by a system VM. Lastly, theallocatedcolumn in theListView, that represents the datetime an IP was allocated, is now parsed and formatted according to the user's timezone.Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
disassociateIpAddressthrough group actions:releaseIpAddressthrough group actions:How Has This Been Tested?
vpc-01) and acquired two additional public IPs;systemtag;allocateddatetime was correctly parsed and formatted according to the timezone in use;systemIPs were not available through group actions ordataView;source-natIPs were not available through group actions ordataView;ReservedIPs.