Support ConfigDrive with VPC

[vishesh92]

Description

This PR fixes #9706

Generated summary

This pull request includes changes to enhance the capabilities and provider configurations for DHCP and DNS services. The changes primarily involve updating the configuration in both the backend and frontend code.

Backend changes:

• server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java: Updated the setCapabilities method to include specific capabilities for DHCP and DNS services.

Frontend changes:

• ui/src/views/offering/AddVpcOffering.vue: Added ConfigDrive as a provider for both DHCP and DNS services in the VPC offering configuration.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 16.00%. Comparing base (b92fd17) to head (c98986a).
Report is 61 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...oud/network/element/ConfigDriveNetworkElement.java	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #10495      +/-   ##
============================================
+ Coverage     15.98%   16.00%   +0.01%     
- Complexity    13086    13104      +18     
============================================
  Files          5650     5651       +1     
  Lines        495756   495843      +87     
  Branches      60018    60045      +27     
============================================
+ Hits          79261    79370     +109     
+ Misses       407641   407611      -30     
- Partials       8854     8862       +8     

Flag	Coverage Δ
uitests	4.00% <ø> (-0.01%)	⬇️
unittests	16.84% <66.66%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12647

[vishesh92]

@blueorangutan test keepEnv

[blueorangutan]

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12556)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58476 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10495-t12556-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deployVMInSharedNetwork	Failure	5.48	test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:teardown	Error	6.58	test_network.py
test_06_purge_expunged_vm_background_task	Failure	399.86	test_purge_expunged_vms.py

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12758

[vishesh92]

@blueorangutan test

[blueorangutan]

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[Pearl1594]

code lgtm

[kiranchavala]

@vishesh92

Getting the following exception message after following these steps

1. Create a vpc offering with the following supported services

2. Create a vpc network offering with the following supported services

3. Create a vpc >> created successfully

4. Create vpc tier with network offering in step2 >> exception

Logs

2025-03-18 06:21:13,579 DEBUG [c.c.a.ApiServlet] (qtp1390913202-24:[ctx-96c1feff]) (logid:b7dcaa8a) ===START===  10.0.3.251 -- GET  vpcid=3e7bb50c-5293-4eb6-970c-63de57fdac0e&domainid=e2d0372e-03b9-11f0-8e52-1e008e000441&account=admin&networkOfferingId=443c4dc2-2a90-46cd-ae2b-e4e0f6ddca15&name=tier1&displayText=tier1&gateway=10.0.0.254&netmask=255.255.255.0&zoneId=750ce0c0-beef-4050-a3fd-e1dc96a8d435&aclid=fb40f16f-03b9-11f0-8e52-1e008e000441&command=createNetwork&response=json&sessionkey=XnqdGh2zpr_P2J7_9u80ECCcEDQ
2025-03-18 06:21:13,579 DEBUG [c.c.a.ApiServlet] (qtp1390913202-24:[ctx-96c1feff]) (logid:b7dcaa8a) Two factor authentication is already verified for the user 2, so skipping
2025-03-18 06:21:13,584 DEBUG [c.c.a.ApiServer] (qtp1390913202-24:[ctx-96c1feff, ctx-46b6c85e]) (logid:b7dcaa8a) CIDRs from which account 'Account [{"accountName":"admin","id":2,"uuid":"29d75d84-03ba-11f0-8e52-1e008e000441"}]' is allowed to perform API calls: 0.0.0.0/0,::/0
2025-03-18 06:21:13,585 INFO  [o.a.c.a.DynamicRoleBasedAPIAccessChecker] (qtp1390913202-24:[ctx-96c1feff, ctx-46b6c85e]) (logid:b7dcaa8a) Account for user id 29d80648-03ba-11f0-8e52-1e008e000441 is Root Admin or Domain Admin, all APIs are allowed.
2025-03-18 06:21:13,585 DEBUG [o.a.c.a.StaticRoleBasedAPIAccessChecker] (qtp1390913202-24:[ctx-96c1feff, ctx-46b6c85e]) (logid:b7dcaa8a) RoleService is enabled. We will use it instead of StaticRoleBasedAPIAccessChecker.
2025-03-18 06:21:13,585 DEBUG [o.a.c.r.ApiRateLimitServiceImpl] (qtp1390913202-24:[ctx-96c1feff, ctx-46b6c85e]) (logid:b7dcaa8a) API rate limiting is disabled. We will not use ApiRateLimitService.
2025-03-18 06:21:13,614 DEBUG [c.c.u.AccountManagerImpl] (qtp1390913202-24:[ctx-96c1feff, ctx-46b6c85e]) (logid:b7dcaa8a) Access granted to Account [{"accountName":"admin","id":2,"uuid":"29d75d84-03ba-11f0-8e52-1e008e000441"}] to Domain {"id":1,"name":"ROOT","path":"\/","uuid":"e2d0372e-03b9-11f0-8e52-1e008e000441"} by AffinityGroupAccessChecker
2025-03-18 06:21:13,622 DEBUG [c.c.u.AccountManagerImpl] (qtp1390913202-24:[ctx-96c1feff, ctx-46b6c85e]) (logid:b7dcaa8a) Access granted to Account [{"accountName":"admin","id":2,"uuid":"29d75d84-03ba-11f0-8e52-1e008e000441"}] to NetworkOffering {"id":13,"name":"DefaultIsolatedNetworkOfferingForVpcNetworks","trafficType":"Guest","uuid":"443c4dc2-2a90-46cd-ae2b-e4e0f6ddca15"} by AffinityGroupAccessChecker
2025-03-18 06:21:13,636 WARN  [c.c.n.NetworkServiceImpl] (qtp1390913202-24:[ctx-96c1feff, ctx-46b6c85e]) (logid:b7dcaa8a) VPC public MTU already set at VPC creation phase to: 1500. Ignoring public MTU passed during VPC network tier creation
2025-03-18 06:21:13,651 DEBUG [c.c.n.v.VpcManagerImpl] (qtp1390913202-24:[ctx-96c1feff, ctx-46b6c85e]) (logid:b7dcaa8a) Releasing lock for VPC {"id":1,"name":"vpc1","uuid":"3e7bb50c-5293-4eb6-970c-63de57fdac0e"}
2025-03-18 06:21:13,660 DEBUG [c.c.u.d.T.Transaction] (qtp1390913202-24:[ctx-96c1feff, ctx-46b6c85e]) (logid:b7dcaa8a) Rolling back the transaction: Time = 19 Name =  qtp1390913202-24; called by -TransactionLegacy.rollback:896-TransactionLegacy.removeUpTo:839-TransactionLegacy.close:663-Transaction.execute:36-NetworkServiceImpl.commitNetwork:2249-NetworkServiceImpl.createGuestNetwork:1800-NativeMethodAccessorImpl.invoke0:-2-NativeMethodAccessorImpl.invoke:77-DelegatingMethodAccessorImpl.invoke:43-Method.invoke:569-AopUtils.invokeJoinpointUsingReflection:344-ReflectiveMethodInvocation.invokeJoinpoint:198
2025-03-18 06:21:13,662 WARN  [o.a.c.m.w.WebhookServiceImpl] (qtp1390913202-24:[ctx-96c1feff, ctx-46b6c85e]) (logid:b7dcaa8a) Skipping delivering event Event {"description":"{\"event\":\"NETWORK.CREATE\",\"status\":\"Completed\"}","eventId":null,"eventType":"NETWORK.CREATE","eventUuid":null,"resourceType":"Network","resourceUUID":null} to any webhook as account ID is missing
2025-03-18 06:21:13,662 WARN  [o.a.c.f.e.EventDistributorImpl] (qtp1390913202-24:[ctx-96c1feff, ctx-46b6c85e]) (logid:b7dcaa8a) Failed to publish event [category: ActionEvent, type: NETWORK.CREATE] on bus webhookEventBus
2025-03-18 06:21:13,669 INFO  [c.c.a.ApiServer] (qtp1390913202-24:[ctx-96c1feff, ctx-46b6c85e]) (logid:b7dcaa8a) Service/provider combination Dhcp/VpcVirtualRouter is not supported by VPC VPC {"id":1,"name":"vpc1","uuid":"3e7bb50c-5293-4eb6-970c-63de57fdac0e"}
2025-03-18 06:21:13,670 INFO  [c.c.a.ApiServlet] (qtp1390913202-24:[ctx-96c1feff, ctx-46b6c85e]) (logid:b7dcaa8a) (userId=2 accountId=2 sessionId=node01lz1n22camp9tfx2lzvuaqmky3) 10.0.3.251 -- GET vpcid=3e7bb50c-5293-4eb6-970c-63de57fdac0e&domainid=e2d0372e-03b9-11f0-8e52-1e008e000441&account=admin&networkOfferingId=443c4dc2-2a90-46cd-ae2b-e4e0f6ddca15&name=tier1&displayText=tier1&gateway=10.0.0.254&netmask=255.255.255.0&zoneId=750ce0c0-beef-4050-a3fd-e1dc96a8d435&aclid=fb40f16f-03b9-11f0-8e52-1e008e000441&command=createNetwork&response=json&sessionkey=XnqdGh2zpr_P2J7_9u80ECCcEDQ 431 Service/provider combination Dhcp/VpcVirtualRouter is not supported by VPC VPC {"id":1,"name":"vpc1","uuid":"3e7bb50c-5293-4eb6-970c-63de57fdac0e"}
2025-03-18 06:21:13,670 DEBUG [c.c.a.ApiServlet] (qtp1390913202-24:[ctx-96c1feff, ctx-46b6c85e]) (logid:b7dcaa8a) ===END===  10.0.3.251 -- GET  vpcid=3e7bb50c-5293-4eb6-970c-63de57fdac0e&domainid=e2d0372e-03b9-11f0-8e52-1e008e000441&account=admin&networkOfferingId=443c4dc2-2a90-46cd-ae2b-e4e0f6ddca15&name=tier1&displayText=tier1&gateway=10.0.0.254&netmask=255.255.255.0&zoneId=750ce0c0-beef-4050-a3fd-e1dc96a8d435&aclid=fb40f16f-03b9-11f0-8e52-1e008e000441&command=createNetwork&response=json&sessionkey=XnqdGh2zpr_P2J7_9u80ECCcEDQ

[blueorangutan]

[SF] Trillian test result (tid-12740)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53752 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10495-t12740-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[shwstppr]

Code lgtm

[vishesh92]

@kiranchavala I am able to create the Network in the VPC. Please check if you selected the correct offering while creating the network.

[kiranchavala]

LGTM

Tested the creation of vpc network offering with configdrive was able to launch the vm successfully