Deal with crosssite api call after login. #10533

DaanHoogland · 2025-03-09T19:37:33Z

Description

This PR...

Fixes: #10522

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-03-09T19:45:44Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.00%. Comparing base (b8359e8) to head (8aae38e).
⚠️ Report is 334 commits behind head on 4.20.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10533   +/-   ##
=========================================
  Coverage     16.00%   16.00%           
+ Complexity    13104    13103    -1     
=========================================
  Files          5651     5651           
  Lines        495841   495842    +1     
  Branches      60044    60044           
=========================================
+ Hits          79365    79368    +3     
  Misses       407613   407613           
+ Partials       8863     8861    -2

Flag	Coverage Δ
uitests	`4.00% <ø> (-0.01%)`	⬇️
unittests	`16.84% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This reverts commit 9b03c78.

ui/src/store/modules/user.js

Co-authored-by: Vishesh <[email protected]>

DaanHoogland · 2025-03-10T09:54:43Z

@blueorangutan ui

blueorangutan · 2025-03-10T09:56:04Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-03-10T10:13:52Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10533 (QA-JID-575)

vishesh92 · 2025-03-10T10:37:24Z

@blueorangutan package

blueorangutan · 2025-03-10T10:38:05Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-10T10:57:26Z

Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12718

blueorangutan · 2025-03-10T11:49:23Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12719

rohityadavcloud · 2025-04-22T04:08:36Z

ui/src/store/modules/user.js

    SetCsLatestVersion ({ commit }, rolename) {
+      if (!vueProps.$config.notifyLatestCSVersion) {
+        return
+      }


Maybe instead of Github, we should query one of the ASF or repo links to find latest release? For example - https://dlcdn.apache.org/cloudstack/releases/ - we may even introduce to put like a file that gives latest version info say from https://download.cloudstack.org/

@rohityadavcloud , I am not sure this would be easily cleanly implemented.

https://api.github.com/repos/apache/cloudstack/releases give a cleanish yaml with results.

In contrast https://dlcdn.apache.org/cloudstack/releases/ gives a directory listing.
https://download.cloudstack.org/ also gives a directory listing which is really messy.

I would prefer to continue as is but make the retrieval of new version optional, advising operators to set it on test environments and to disable it in production.

What do you think?

can we just put a file on cloudstack.apache.org, for example

https://cloudstack.apache.org/latest_cloudstack_version ?

We do not need to get the new version very soon after the release, 1-7 days delay is good I think.

shwstppr

Like the idea of making the version check configurable.
One issue I see with our current approach of storing fetched version in store is that if the admin logs in 50 times in an Incognito window it will query for version 50 times.

Maybe we can also improve the overall readability of SetCsLatestVersion

diff --git a/ui/src/store/modules/user.js b/ui/src/store/modules/user.js
index 6113f3ed94..5b724d1664 100644
--- a/ui/src/store/modules/user.js
+++ b/ui/src/store/modules/user.js
@@ -556,27 +556,32 @@ const user = {
       commit('SET_DOMAIN_STORE', domainStore)
     },
     SetCsLatestVersion ({ commit }, rolename) {
-      const lastFetchTs = store.getters.latestVersion?.fetchedTs ? store.getters.latestVersion.fetchedTs : 0
-      if (rolename === 'Root Admin' && (+new Date() - lastFetchTs) > 24 * 60 * 60 * 1000) {
-        axios.get(
-          'https://api.github.com/repos/apache/cloudstack/releases'
-        ).then(response => {
-          let latestReleaseVersion = getParsedVersion(response[0].tag_name)
-          let latestTag = response[0].tag_name
-
-          for (const release of response) {
-            if (release.tag_name.toLowerCase().includes('rc')) {
-              continue
-            }
-            const parsedVersion = getParsedVersion(release.tag_name)
-            if (semver.gte(parsedVersion, latestReleaseVersion)) {
-              latestReleaseVersion = parsedVersion
-              latestTag = release.tag_name
-              commit('SET_LATEST_VERSION', { version: latestTag, fetchedTs: (+new Date()) })
-            }
-          }
-        }).catch(ignored => {})
+      if (!vueProps.$config.notifyLatestCSVersion) {
+        return
       }
+      const lastFetchTs = store.getters.latestVersion?.fetchedTs || 0
+      if (rolename !== 'Root Admin' || (+new Date() - lastFetchTs) <= 24 * 60 * 60 * 1000) {
+        return
+      }
+      let lastFetchedVersion = store.getters.latestVersion?.version || '0.0.0'
+      const parsedLastFetchedVersion = getParsedVersion(lastFetchedVersion)
+      axios.get(
+        'https://api.github.com/repos/apache/cloudstack/releases'
+      ).then(response => {
+        for (const release of response) {
+          if (release.tag_name.toLowerCase().includes('rc') || release.draft || release.prerelease) {
+            continue
+          }
+          const parsedVersion = getParsedVersion(release.tag_name)
+          if (semver.gte(getParsedVersion(release.tag_name), parsedLastFetchedVersion)) {
+            lastFetchedVersion = release.tag_name
+            break
+          }
+        }
+      }).catch(ignored => {
+      }).finally(() => {
+        commit('SET_LATEST_VERSION', { version: lastFetchedVersion, fetchedTs: (+new Date()) })
+      })
     },
     SetDarkMode ({ commit }, darkMode) {
       commit('SET_DARK_MODE', darkMode)

shwstppr · 2025-09-24T11:44:13Z

ui/src/store/modules/user.js

            const result = response.listusersresponse.user[0]
            commit('SET_INFO', result)
            commit('SET_NAME', result.firstname + ' ' + result.lastname)
-            store.dispatch('SetCsLatestVersion', result.rolename)


should this be removed?

This fixes the issue where it is making 2 API calls.

NuxRo · 2025-10-03T09:57:37Z

Good feature, but anything that makes CloudStack rely on external resources should be disable-able.

Some/Many corporate environments are run in closed down intranets where this is causing UI errors and generating reports from users. I know of at least 2 such situations.

vishesh92 · 2025-10-03T11:45:50Z

Tested this PR. This works as expected. When notifyLatestCSVersion is set to false, no requests are made to github.

weizhouapache · 2025-10-06T06:59:28Z

Tested this PR. This works as expected. When notifyLatestCSVersion is set to false, no requests are made to github.

thanks @vishesh92
if notifyLatestCSVersion is set to true, how many requests are sent to github ?

vishesh92 · 2025-10-06T07:03:45Z

Tested this PR. This works as expected. When notifyLatestCSVersion is set to false, no requests are made to github.

thanks @vishesh92 if notifyLatestCSVersion is set to true, how many requests are sent to github ?

In case of failures, it was sent twice earlier. Now it's sent only once.

weizhouapache

code lgtm

thanks @vishesh92
can you approve it ?

remove double listUsers call

9b03c78

boring-cyborg bot added the component:UI label Mar 9, 2025

DaanHoogland linked an issue Mar 9, 2025 that may be closed by this pull request

Two API requests done towards api.github.com anytime someone visits ACS UI #10522

Closed

DaanHoogland mentioned this pull request Mar 9, 2025

Two API requests done towards api.github.com anytime someone visits ACS UI #10522

Closed

DaanHoogland added 3 commits March 10, 2025 09:03

Revert "remove double listUsers call"

9c4fb52

This reverts commit 9b03c78.

remove second cross check to github

7c041f9

add option to cross check versions

232df43

DaanHoogland requested a review from vishesh92 March 10, 2025 09:31

apache deleted a comment from blueorangutan Mar 10, 2025

vishesh92 reviewed Mar 10, 2025

View reviewed changes

ui/src/store/modules/user.js Outdated Show resolved Hide resolved

Update ui/src/store/modules/user.js

8aae38e

Co-authored-by: Vishesh <[email protected]>

apache deleted a comment from blueorangutan Mar 10, 2025

Pearl1594 requested a review from vishesh92 March 14, 2025 16:05

rohityadavcloud requested review from Pearl1594 and shwstppr March 18, 2025 03:26

rohityadavcloud added this to the 4.20.1 milestone Mar 18, 2025

rohityadavcloud reviewed Apr 22, 2025

View reviewed changes

Pearl1594 modified the milestones: 4.20.1, 4.20.2 Jun 3, 2025

weizhouapache modified the milestones: 4.20.2, 4.20.3 Sep 10, 2025

shwstppr reviewed Sep 24, 2025

View reviewed changes

DaanHoogland marked this pull request as ready for review October 3, 2025 17:52

weizhouapache approved these changes Oct 6, 2025

View reviewed changes

vishesh92 approved these changes Oct 6, 2025

View reviewed changes

weizhouapache merged commit 270d3f9 into apache:4.20 Oct 8, 2025
26 checks passed

weizhouapache modified the milestones: 4.20.3, 4.20.2 Oct 8, 2025

DaanHoogland deleted the ghi10522-crosssiteAPIcall branch October 8, 2025 11:32

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025

UI: Deal with crosssite api call after login (apache#10533)

7ca5977

sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Oct 21, 2025

UI: Deal with crosssite api call after login (apache#10533)

9b8d822

Deal with crosssite api call after login. #10533

Deal with crosssite api call after login. #10533

Uh oh!

Conversation

DaanHoogland commented Mar 9, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Mar 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

DaanHoogland commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

vishesh92 commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

rohityadavcloud Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

weizhouapache Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

vishesh92 Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

NuxRo commented Oct 3, 2025

Uh oh!

vishesh92 commented Oct 3, 2025

Uh oh!

weizhouapache commented Oct 6, 2025

Uh oh!

vishesh92 commented Oct 6, 2025

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov bot commented Mar 9, 2025 •

edited

Loading