Veeam BnR : Fix for error in remove backup offering

[abh1sar]

Description

This PR fixes #9896

Issue was that veeam /jobs/ api was being sent with 'null' value.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested that backup offering was removed without any error logs

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (90c960e) to head (7bb51b4).
Report is 36 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
.../apache/cloudstack/backup/VeeamBackupProvider.java	0.00%	2 Missing ⚠️
...rg/apache/cloudstack/backup/BackupManagerImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               4.19   #10562    +/-   ##
==========================================
  Coverage     15.16%   15.16%            
- Complexity    11314    11328    +14     
==========================================
  Files          5409     5414     +5     
  Lines        474473   474806   +333     
  Branches      57876    57910    +34     
==========================================
+ Hits          71947    72008    +61     
- Misses       394482   394745   +263     
- Partials       8044     8053     +9     

Flag	Coverage Δ
uitests	4.28% <ø> (-0.01%)	⬇️
unittests	15.89% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

code lgtm

not tested

[abh1sar]

@blueorangutan package

[blueorangutan]

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12768

[Pearl1594]

@blueorangutan test

[blueorangutan]

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-12682)

[Pearl1594]

@blueorangutan test

[Pearl1594]

code lgtm

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12691)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48132 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10562-t12691-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File