Add download link of volumes, templates and ISOs to the download event details

[bernardodemarco]

Description

When the download of templates, ISOs and volumes is finished, a download link is generated and displayed to end users in a notification. However, in situations in which the download process takes a large amount of time, the user's authentication session may be expired by inactivity and, thus, the reference to the link gets lost.

Therefore, this PR proposes to add the templates, ISOs and volumes download links to the details of the TEMPLATE.EXTRACT, ISO.EXTRACT and VOLUME.EXTRACT events, respectively. As a consequence of that, in scenarios that users sessions are expired when downloading such resources, the event details can be accessed by users to retrieve the download link.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Screenshots (if appropriate):

• TEMPLATE.EXTRACT event details:

• ISO.EXTRACT event details:

• VOLUME.EXTRACT event details:

How Has This Been Tested?

• Verified that when the templates extraction process is completed, the TEMPLATE.EXTRACT event description is generated with the template download URL.
• Verified that when the ISOs extraction process is completed, the ISO.EXTRACT event description is generated with the ISO download URL.
• Verified that when the volume extraction process is completed for root disks, the VOLUME.EXTRACT event description is generated with the volume download URL.
• Verified that when the volume extraction process is completed for attached data disks, the VOLUME.EXTRACT event description is generated with the volume download URL.
• Verified that when the volume extraction process is completed for detached data disks, the VOLUME.EXTRACT event description is generated with the volume download URL.

[bernardodemarco]

@blueorangutan package

[blueorangutan]

@bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 16.00%. Comparing base (f8adedc) to head (61f6e47).
Report is 33 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	0.00%	12 Missing ⚠️
...cloudstack/api/command/user/iso/ExtractIsoCmd.java	0.00%	6 Missing ⚠️
.../api/command/user/template/ExtractTemplateCmd.java	0.00%	6 Missing ⚠️
...n/java/com/cloud/template/TemplateManagerImpl.java	0.00%	6 Missing ⚠️
...tack/api/command/user/volume/ExtractVolumeCmd.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10564   +/-   ##
=========================================
  Coverage     16.00%   16.00%           
- Complexity    13104    13105    +1     
=========================================
  Files          5651     5651           
  Lines        495843   495867   +24     
  Branches      60045    60047    +2     
=========================================
+ Hits          79363    79372    +9     
- Misses       407624   407633    +9     
- Partials       8856     8862    +6     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	16.84% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Pearl1594]

code lgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12770

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-12683)

[erikbocks]

LGTM, tested it for templates, ISOs and for attached and dettached volumes.
All the download links could be found in the Events tab.

[bernardodemarco]

Thanks for testing it, @erikbocks!

[bernardodemarco]

@Pearl1594 can we run the CI for this one?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13041

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12980)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54092 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10564-t12980-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File