Hide CloudStack version from XML response when unauthenticated #10575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10575 +/- ##
=========================================
Coverage 16.26% 16.26%
+ Complexity 13388 13387 -1
=========================================
Files 5674 5674
Lines 498929 498938 +9
Branches 60338 60341 +3
=========================================
+ Hits 81154 81157 +3
- Misses 408736 408741 +5
- Partials 9039 9040 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DaanHoogland
approved these changes
Mar 19, 2025
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
code looks good @gpordeus , but can I ask you to remove all the log.append() calls and only append sb to log, just before returning at line 211?
Not your doing for sure, but the code looks a bit silly like this.
JoaoJandre
approved these changes
Mar 24, 2025
winterhazel
approved these changes
Mar 24, 2025
Member
winterhazel
left a comment
winterhazel
left a comment
There was a problem hiding this comment.
Tested manually:
- Verified that XML responses do not contain the version when the user is not authenticated, independently of
expose.cloudstack.version.api.xml.response - Verified that XML responses contain the version when user is authenticated and
expose.cloudstack.version.api.xml.responseis set to true - Verified that XML responses do not contain the version when user is authenticated and
expose.cloudstack.version.api.xml.responseis set to false - Verified that
listCapabilitiesreturns the version whenexpose.cloudstack.version.api.list.capabilitiesis set to true - Verified that
listCapabilitiesdoes not return the version whenexpose.cloudstack.version.api.list.capabilitiesis set to false
Collaborator
Author
|
@DaanHoogland While I agree it is silly, it would take bigger changes to clean it up and demand more testing. |
Contributor
|
@blueorangutan package |
|
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13583 |
Contributor
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-13461) |
Contributor
|
@blueorangutan package |
|
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14044 |
Contributor
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-13692)
|
Contributor
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14139 |
Contributor
|
@blueorangutan test |
|
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-13753)
|
Contributor
|
no response from original author but it looks ready, @nvazquez and had been marked so by @winterhazel. merging. |
github-project-automation
bot
moved this from In Progress
to Done
in Apache CloudStack 4.21.0
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hides the cloudstack version field of XML responses when the caller is unauthenticated (checks if it is SYSTEM account).
It also adds the
expose.cloudstack.version.api.list.capabilitiesto allow hiding the field from thelistCapabilitiesAPI call andexpose.cloudstack.version.api.xml.responseto allow hiding the field from XML responses, both are true by default as to not change compatibility.It does not change the version information in system VMs and VRs.
Fixes: #10072
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Unauthenticated:
Authenticated and configs:
expose.cloudstack.version.api.list.capabilities= true;expose.cloudstack.version.api.xml.response= true;expose.cloudstack.version.api.list.capabilities= false;expose.cloudstack.version.api.xml.response= false;How did you try to break this feature and the system with this change?