Fix smoke test for restore vm strict tags failure

[vishesh92]

Description

This PR fixes the smoke test failure for test_02_restore_vm_strict_tags_failure.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.00%. Comparing base (653b973) to head (915fdea).
Report is 53 commits behind head on 4.20.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10597   +/-   ##
=========================================
  Coverage     16.00%   16.00%           
+ Complexity    13104    13102    -2     
=========================================
  Files          5651     5651           
  Lines        495870   495870           
  Branches      60049    60049           
=========================================
+ Hits          79370    79371    +1     
+ Misses       407638   407637    -1     
  Partials       8862     8862           

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	16.84% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12851

[Pearl1594]

@blueorangutan test matrix

[blueorangutan]

@Pearl1594 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12793)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53996 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10597-t12793-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestRestoreVMStrictTags>:teardown	Error	48.29	test_vm_strict_host_tags.py

[blueorangutan]

[SF] Trillian test result (tid-12794)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 67046 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10597-t12794-kvm-ubuntu22.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_oobm_multiple_mgmt_server_ownership	Failure	30.78	test_outofbandmanagement.py
ContextSuite context=TestRestoreVMStrictTags>:teardown	Error	45.27	test_vm_strict_host_tags.py

[blueorangutan]

[SF] Trillian test result (tid-12795)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 79599 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10597-t12795-vmware-70u3.zip
Smoke tests completed. 132 look OK, 9 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	335.15	test_events_resource.py
test_01_events_resource	Error	335.16	test_events_resource.py
test_deploy_more_vms_than_limit_allows	Error	179.06	test_deploy_vms_in_parallel.py
test_04_list_domains_level_filter	Failure	0.07	test_list_domains.py
test_05_list_domains_no_filter	Failure	0.03	test_list_domains.py
test_05_list_volumes_isrecursive	Failure	0.07	test_list_volumes.py
test_07_list_volumes_listall	Failure	0.06	test_list_volumes.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	Error	120.35	test_network_permissions.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	Error	1523.89	test_network.py
test_02_restore_vm_with_disk_offering	Error	62.21	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	Error	58.23	test_restore_vm.py
ContextSuite context=TestRestoreVMStrictTags>:teardown	Error	57.47	test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success	Error	3607.48	test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success	Error	3605.72	test_vm_strict_host_tags.py
test_01_redundant_vpc_site2site_vpn	Failure	629.19	test_vpc_vpn.py

[blueorangutan]

[SF] Trillian test result (tid-12796)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 84028 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10597-t12796-xcpng82.zip
Smoke tests completed. 135 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_condensed_drs_algorithm	Failure	167.62	test_cluster_drs.py
test_02_balanced_drs_algorithm	Failure	179.77	test_cluster_drs.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	Error	7.59	test_network.py
test_01_non_strict_host_anti_affinity	Error	233.44	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	Error	114.32	test_nonstrict_affinity_group.py
test_02_create_volume	Error	2.24	test_resource_names.py
test_05_scale_vm_dont_allow_disk_offering_change	Failure	69.76	test_scale_vm.py
ContextSuite context=TestRestoreVMStrictTags>:teardown	Error	82.14	test_vm_strict_host_tags.py

[Pearl1594]

@blueorangutan test matrix

[blueorangutan]

@Pearl1594 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-12820)

[blueorangutan]

[SF] Trillian test result (tid-12817)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53786 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10597-t12817-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestRestoreVMStrictTags>:teardown	Error	44.23	test_vm_strict_host_tags.py

[blueorangutan]

[SF] Trillian test result (tid-12818)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 56880 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10597-t12818-kvm-ubuntu22.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_oobm_multiple_mgmt_server_ownership	Failure	31.86	test_outofbandmanagement.py
ContextSuite context=TestRestoreVMStrictTags>:teardown	Error	46.46	test_vm_strict_host_tags.py

[blueorangutan]

[SF] Trillian test result (tid-12819)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 64004 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10597-t12819-vmware-70u3.zip
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	331.26	test_events_resource.py
test_01_events_resource	Error	331.27	test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	Error	116.76	test_network_permissions.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	Error	1522.99	test_network.py
test_02_restore_vm_with_disk_offering	Error	60.27	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	Error	60.29	test_restore_vm.py
ContextSuite context=TestRestoreVMStrictTags>:teardown	Error	54.61	test_vm_strict_host_tags.py

[Pearl1594]

@vishesh92 any update on this?

[blueorangutan]

[SF] Trillian Build Failed (tid-12891)

[blueorangutan]

[SF] Trillian Build Failed (tid-12895)

[blueorangutan]

[SF] Trillian test result (tid-12952)
Environment: vmware-70u3 (x3), Advanced Networking with Mgmt server ol8
Total time taken: 65017 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10597-t12952-vmware-70u3.zip
Smoke tests completed. 135 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	343.46	test_events_resource.py
test_01_events_resource	Error	343.47	test_events_resource.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	Error	585.79	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	Error	595.98	test_internal_lb.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	Error	110.60	test_network_permissions.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	Error	1523.63	test_network.py
test_02_restore_vm_with_disk_offering	Error	60.16	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	Error	58.07	test_restore_vm.py
ContextSuite context=TestRestoreVMStrictTags>:teardown	Error	52.36	test_vm_strict_host_tags.py

[vishesh92]

this has been resolved as part of #10586