Host status auto refresh #10606

Imvedansh · 2025-03-21T19:18:03Z

Description

This PR... fixes #10604 When a user disables/Enables a host from the Infrastructure - Host tab (List view), the UI does not refresh automatically to reflect the new disabled state of the host. The API call succeeds, but the user doesn't see the state change until they manually refresh the page.

#10604

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

Screen.Recording.2025-03-21.at.11.18.17.PM.mov

How Has This Been Tested?

How did you try to break this feature and the system with this change?

bernardodemarco · 2025-03-21T21:35:39Z

@blueorangutan ui

blueorangutan · 2025-03-21T21:36:03Z

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-03-21T21:52:44Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10606 (QA-JID-580)

DaanHoogland · 2025-03-24T10:49:47Z

@Imvedansh , it seems to me you would like this into version 4.20?! You have submitted a change to main (meaning 21). You might want to rebase your changes onto the release branch 4.20.

git rebase --onto 4.20 <commit before your changes> <your latest commit>

codecov · 2025-03-24T10:52:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.89%. Comparing base (c9c02d0) to head (d82fdbb).
Report is 1 commits behind head on 4.19.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10606      +/-   ##
============================================
+ Coverage     15.16%   15.89%   +0.72%     
  Complexity    11330    11330              
============================================
  Files          5414     5046     -368     
  Lines        474811   445155   -29656     
  Branches      57910    52704    -5206     
============================================
- Hits          72021    70749    -1272     
+ Misses       394737   366498   -28239     
+ Partials       8053     7908     -145

Flag	Coverage Δ
uitests	`?`
unittests	`15.89% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-03-24T12:21:27Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Imvedansh · 2025-03-24T12:50:26Z

@DaanHoogland Yes, you are absolutely right! I have rebased onto 4.19, ensuring that the feature can be included in next month's update, will keep you posted!
Thank you much

DaanHoogland · 2025-03-24T15:08:36Z

@blueorangutan ui

blueorangutan · 2025-03-24T15:09:04Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-03-24T15:25:44Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10606 (QA-JID-584)

bernardodemarco · 2025-03-24T15:27:49Z

plugins/storage/volume/linstor/CHANGELOG.md

 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

+


I believe these changes on plugins/storage/volume/linstor/CHANGELOG.md are not necessary, right?

nice cleanup though, aren't they?

Sure , I agree

ui/src/views/infra/HostEnableDisable.vue

bernardodemarco · 2025-03-24T15:42:08Z

ui/src/views/infra/HostEnableDisable.vue

+  width: 30vw;
+  @media (min-width: 500px) {
+    width: 450px;


Are these changes necessary?

just reformat. these are fine aren't they?

no, not often will make a difference, will remove it

Let me just push the feature in first go , and will do the enhancement later on

Imvedansh · 2025-03-24T17:14:30Z

@blueorangutan ui

blueorangutan · 2025-03-24T17:15:04Z

@Imvedansh a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-03-24T17:31:17Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10606 (QA-JID-585)

Imvedansh · 2025-03-24T18:08:13Z

@blueorangutan ui

blueorangutan · 2025-03-24T18:09:04Z

@Imvedansh a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-03-24T18:25:03Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10606 (QA-JID-586)

bernardodemarco

lgtm, tested in the QA environment

DaanHoogland

clgtm

Pearl1594

lgtm

Co-authored-by: Rene Peinthor <[email protected]>

boring-cyborg bot added the component:UI label Mar 21, 2025

Imvedansh changed the base branch from main to 4.19 March 23, 2025 00:37

boring-cyborg bot added component:agent component:build component:integration labels Mar 23, 2025

Imvedansh changed the base branch from 4.19 to 4.19-merge March 23, 2025 00:42

boring-cyborg bot added the component:api label Mar 23, 2025

Imvedansh changed the base branch from 4.19-merge to 4.20 March 23, 2025 00:45

Imvedansh changed the base branch from 4.20 to 4.19 March 23, 2025 00:46

Imvedansh changed the base branch from 4.19 to main March 23, 2025 00:49

Imvedansh changed the base branch from main to 4.19 March 24, 2025 12:14

boring-cyborg bot added component:primary-storage component:storage labels Mar 24, 2025

github-actions bot added the status:has-conflicts label Mar 24, 2025

github-actions bot removed the status:has-conflicts label Mar 24, 2025

DaanHoogland added this to the 4.19.3 milestone Mar 24, 2025

bernardodemarco reviewed Mar 24, 2025

View reviewed changes

bernardodemarco removed component:primary-storage component:api component:agent labels Mar 24, 2025

bernardodemarco removed component:build component:storage component:integration labels Mar 24, 2025

Imvedansh closed this Mar 24, 2025

Imvedansh deleted the Host-status-auto-refresh branch March 24, 2025 17:04

Imvedansh restored the Host-status-auto-refresh branch March 24, 2025 17:04

Imvedansh reopened this Mar 24, 2025

boring-cyborg bot added component:primary-storage component:storage labels Mar 24, 2025

Imvedansh and others added 2 commits March 24, 2025 22:55

testing the feature

19d58e3

Auto update the host status

2392d71

Imvedansh marked this pull request as draft March 24, 2025 17:30

fixed formating

d82fdbb

Imvedansh marked this pull request as ready for review March 24, 2025 18:31

bernardodemarco approved these changes Mar 25, 2025

View reviewed changes

DaanHoogland approved these changes Mar 25, 2025

View reviewed changes

Pearl1594 approved these changes Mar 25, 2025

View reviewed changes

Pearl1594 added this to ACS 4.20.1 Mar 25, 2025

DaanHoogland merged commit fc1f260 into apache:4.19 Mar 25, 2025
26 checks passed

github-project-automation bot moved this to Done in ACS 4.20.1 Mar 25, 2025

Pearl1594 moved this from Done to In Progress in ACS 4.20.1 Mar 25, 2025

DaanHoogland mentioned this pull request Mar 25, 2025

In the Infrastructure -Host tab (List view) when you disable/Enable the host, it doesn't refresh the page, User doesn't see the updated status. #10604

Closed

Pearl1594 moved this from In Progress to Done in ACS 4.20.1 Mar 26, 2025

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025

Host status auto refresh (apache#10606)

f3bcf3f

Co-authored-by: Rene Peinthor <[email protected]>

		The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
		and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

Host status auto refresh #10606

Host status auto refresh #10606

Uh oh!

Conversation

Imvedansh commented Mar 21, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

bernardodemarco commented Mar 21, 2025

Uh oh!

blueorangutan commented Mar 21, 2025

Uh oh!

blueorangutan commented Mar 21, 2025

Uh oh!

DaanHoogland commented Mar 24, 2025

Uh oh!

codecov bot commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

Imvedansh commented Mar 24, 2025

Uh oh!

DaanHoogland commented Mar 24, 2025

Uh oh!

blueorangutan commented Mar 24, 2025

Uh oh!

blueorangutan commented Mar 24, 2025

Uh oh!

bernardodemarco Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

Imvedansh Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bernardodemarco Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

Imvedansh Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

Imvedansh Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

Imvedansh commented Mar 24, 2025

Uh oh!

blueorangutan commented Mar 24, 2025

Uh oh!

blueorangutan commented Mar 24, 2025

Uh oh!

Imvedansh commented Mar 24, 2025

Uh oh!

blueorangutan commented Mar 24, 2025

Uh oh!

blueorangutan commented Mar 24, 2025

Uh oh!

bernardodemarco left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Pearl1594 left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 24, 2025 •

edited

Loading