check for custom offering and trim size

[DaanHoogland]

Description

This PR...

Fixes: #10627

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.16%. Comparing base (3afab9a) to head (afb263d).
Report is 27 commits behind head on 4.19.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10629      +/-   ##
============================================
- Coverage     15.16%   15.16%   -0.01%     
+ Complexity    11328    11326       -2     
============================================
  Files          5414     5414              
  Lines        474814   474816       +2     
  Branches      57911    57912       +1     
============================================
- Hits          72026    72021       -5     
- Misses       394734   394740       +6     
- Partials       8054     8055       +1     

Flag	Coverage Δ
uitests	4.28% <ø> (-0.01%)	⬇️
unittests	15.89% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

in my opinion, if we consider it as a bug, the bug exists in almost all input area on UI

we'd better trim all input area, not only this one.

[DaanHoogland]

I agree @weizhouapache but it would still be a case by case solution in a lot of cases (including this one) as the condition is for it to be done is conspicuous. Also I doubt this is always desirable like in description fields and other non-numerical fields. Alternatively we might opt for a solution in the API that handles numerical fields automatically.

[weizhouapache]

I agree @weizhouapache but it would still be a case by case solution in a lot of cases (including this one) as the condition is for it to be done is conspicuous. Also I doubt this is always desirable like in description fields and other non-numerical fields. Alternatively we might opt for a solution in the API that handles numerical fields automatically.

@DaanHoogland
I like your idea to hand/trim the input in API server

ps: if vm name has trailing spaces, deployment fails

ps2: if volume is created with name "asd ", searching volumes by name "asd" will return empty result.