Smoke tests: Xenserver - Fix consistent failure noticed on scale VM test #10741

Pearl1594 · 2025-04-16T18:20:07Z

Description

This PR fixes consistent failure noticed on the test_scale_vm.py test suite:
#10668 (comment)

Using the centos template as the Macchinina template registered with "Other Linux (64-bit)" does not have guest_os_details for min and max dynamic memory to be used during scaling by xenserver. Which results in failure of the test as it fails to meet the constraints of

0 <= memory-static-min(512MB) <= memory-dynamic-min(1024MB) <= memory-dynamic-max(1024MV) <= memory-static-max(512MB)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Pearl1594 · 2025-04-16T18:23:00Z

@blueorangutan package

codecov · 2025-04-16T18:23:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.09%. Comparing base (207a2c1) to head (ba10f80).
Report is 23 commits behind head on 4.20.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #10741      +/-   ##
============================================
+ Coverage     16.02%   16.09%   +0.07%     
- Complexity    13124    13229     +105     
============================================
  Files          5652     5652              
  Lines        495921   498496    +2575     
  Branches      60053    61109    +1056     
============================================
+ Hits          79463    80239     +776     
- Misses       407593   409307    +1714     
- Partials       8865     8950      +85

Flag	Coverage Δ
uitests	`3.98% <ø> (-0.02%)`	⬇️
unittests	`16.94% <ø> (+0.07%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache · 2025-04-17T07:29:39Z

@blueorangutan package

weizhouapache · 2025-04-17T07:29:57Z

good finding @Pearl1594

DaanHoogland · 2025-04-17T08:27:49Z

@blueorangutan package

blueorangutan · 2025-04-17T08:30:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Pearl1594 · 2025-04-17T08:48:54Z

I still think there is an underlying issue / behavioural change. Because this seems to have been working until 4.19 - this specific test fails from 4.20

weizhouapache · 2025-04-17T08:58:37Z

I still think there is an underlying issue / behavioural change. Because this seems to have been working until 4.19 - this specific test fails from 4.20

ah ok, so some changes in 4.20 causes it ?

blueorangutan · 2025-04-17T10:04:19Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13092

blueorangutan · 2025-04-17T14:06:04Z

@DaanHoogland [SL] unsupported parameters provided. Supported mgmt server os are: ol8, ol9, debian12, rocky8, alma9, suse15, centos7, centos6, alma8, ubuntu18, ubuntu22, ubuntu20, ubuntu24. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-rocky8, kvm-ol8, kvm-ol9, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-ubuntu24, kvm-debian12, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, vmware-80u2, vmware-80u3, xenserver-65sp1, xenserver-71, xenserver-74, xenserver-84, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82, xcpng83

DaanHoogland · 2025-04-17T14:39:54Z

@blueorangutan test ol8 xenserver-74

blueorangutan · 2025-04-17T14:42:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + xenserver-74) has been kicked to run smoke tests

blueorangutan · 2025-04-17T15:11:02Z

[SF] Trillian Build Failed (tid-13039)

DaanHoogland · 2025-04-17T15:45:45Z

@blueorangutan test ol8 xenserver-84

blueorangutan · 2025-04-17T15:48:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + xenserver-84) has been kicked to run smoke tests

blueorangutan · 2025-04-17T16:44:52Z

[SF] Trillian Build Failed (tid-13044)

Pearl1594 · 2025-04-18T22:50:43Z

@blueorangutan test ol8 xcpng76

blueorangutan · 2025-04-18T22:52:03Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng76) has been kicked to run smoke tests

Pearl1594 · 2025-04-18T22:52:32Z

@blueorangutan test ol8 xcpng82

blueorangutan · 2025-04-18T22:54:03Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng82) has been kicked to run smoke tests

blueorangutan · 2025-04-18T23:31:17Z

[SF] Trillian Build Failed (tid-13062)

blueorangutan · 2025-04-18T23:48:50Z

[SF] Trillian Build Failed (tid-13061)

Pearl1594 · 2025-04-21T03:47:05Z

@blueorangutan test ol8 xcpng82

blueorangutan · 2025-04-21T03:48:03Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng82) has been kicked to run smoke tests

blueorangutan · 2025-04-22T01:29:41Z

[SF] Trillian test result (tid-13069)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 76000 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10741-t13069-xcpng82.zip
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_condensed_drs_algorithm	`Failure`	156.20	test_cluster_drs.py
test_02_balanced_drs_algorithm	`Failure`	184.31	test_cluster_drs.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	`Error`	10.56	test_network.py
test_01_non_strict_host_anti_affinity	`Error`	230.49	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	115.52	test_nonstrict_affinity_group.py
test_02_create_volume	`Error`	4.29	test_resource_names.py
test_05_scale_vm_dont_allow_disk_offering_change	`Failure`	273.20	test_scale_vm.py

Pearl1594 · 2025-04-22T05:37:05Z

This test seems to work fine on Xen / xcp versions < 8 - Since we use centos template - which doesnt have guest tools installed, scale VM seems to fail.

Pearl1594 · 2025-04-22T07:36:07Z

@blueorangutan package

blueorangutan · 2025-04-22T07:38:07Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sonarqubecloud · 2025-04-22T07:46:35Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

blueorangutan · 2025-04-22T09:15:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13129

Pearl1594 · 2025-04-22T09:16:59Z

@blueorangutan test matrix

blueorangutan · 2025-04-22T09:18:04Z

@Pearl1594 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

blueorangutan · 2025-04-23T02:44:23Z

[SF] Trillian test result (tid-13079)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 60502 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10741-t13079-kvm-ubuntu22.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_oobm_multiple_mgmt_server_ownership	`Failure`	31.88	test_outofbandmanagement.py
test_create_pvlan_network	`Error`	0.11	test_pvlan.py
test_02_restore_vm_strict_tags_failure	`Failure`	55.74	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Failure`	59.07	test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure	`Failure`	3.93	test_vm_strict_host_tags.py

blueorangutan · 2025-04-23T03:52:58Z

[SF] Trillian test result (tid-13078)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 63958 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10741-t13078-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_restore_vm_strict_tags_failure	`Failure`	61.81	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Failure`	61.19	test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure	`Failure`	4.00	test_vm_strict_host_tags.py

blueorangutan · 2025-04-23T07:39:34Z

[SF] Trillian test result (tid-13080)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 77974 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10741-t13080-vmware-70u3.zip
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	342.72	test_events_resource.py
test_01_events_resource	`Error`	342.73	test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	`Error`	123.57	test_network_permissions.py
test_01_deployVMInSharedNetwork	`Failure`	3606.40	test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:teardown	`Error`	3607.73	test_network.py
test_02_restore_vm_with_disk_offering	`Error`	60.78	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	`Error`	65.69	test_restore_vm.py
test_02_restore_vm_strict_tags_failure	`Failure`	63.87	test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure	`Error`	63.87	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Failure`	66.06	test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure	`Failure`	5.85	test_vm_strict_host_tags.py

blueorangutan · 2025-04-23T09:05:41Z

[SF] Trillian test result (tid-13081)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 83440 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10741-t13081-xcpng82.zip
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_condensed_drs_algorithm	`Failure`	170.47	test_cluster_drs.py
test_02_balanced_drs_algorithm	`Failure`	161.90	test_cluster_drs.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	`Error`	10.62	test_network.py
test_01_non_strict_host_anti_affinity	`Error`	253.26	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	121.25	test_nonstrict_affinity_group.py
test_02_create_volume	`Error`	3.25	test_resource_names.py
test_02_restore_vm_strict_tags_failure	`Failure`	95.36	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Failure`	98.72	test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure	`Failure`	5.72	test_vm_strict_host_tags.py

harikrishna-patnala

code LGTM

weizhouapache

code lgtm

smoke tests look good

…est (apache#10741) * Smoke tests: Xenserver - Fix consistent failure noticed on scale VM test * update test

Smoke tests: Xenserver - Fix consistent failure noticed on scale VM test

edf7659

boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Apr 16, 2025

Pearl1594 added this to the 4.20.1 milestone Apr 16, 2025

update test

ba10f80

Pearl1594 requested review from harikrishna-patnala and shwstppr April 23, 2025 04:25

Pearl1594 added this to ACS 4.20.1 Apr 23, 2025

Pearl1594 moved this to In Progress in ACS 4.20.1 Apr 23, 2025

Pearl1594 requested a review from weizhouapache April 25, 2025 08:34

harikrishna-patnala approved these changes Apr 25, 2025

View reviewed changes

weizhouapache approved these changes Apr 25, 2025

View reviewed changes

weizhouapache merged commit 1adfaf9 into 4.20 Apr 25, 2025
43 of 50 checks passed

github-project-automation bot moved this from In Progress to Done in ACS 4.20.1 Apr 25, 2025

Pearl1594 deleted the fix-scalevm-test branch April 25, 2025 08:52

Smoke tests: Xenserver - Fix consistent failure noticed on scale VM test #10741

Smoke tests: Xenserver - Fix consistent failure noticed on scale VM test #10741

Uh oh!

Conversation

Pearl1594 commented Apr 16, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

Pearl1594 commented Apr 16, 2025

Uh oh!

codecov bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache commented Apr 17, 2025

Uh oh!

weizhouapache commented Apr 17, 2025

Uh oh!

DaanHoogland commented Apr 17, 2025

Uh oh!

blueorangutan commented Apr 17, 2025

Uh oh!

Pearl1594 commented Apr 17, 2025

Uh oh!

weizhouapache commented Apr 17, 2025

Uh oh!

blueorangutan commented Apr 17, 2025

Uh oh!

blueorangutan commented Apr 17, 2025

Uh oh!

DaanHoogland commented Apr 17, 2025

Uh oh!

blueorangutan commented Apr 17, 2025

Uh oh!

blueorangutan commented Apr 17, 2025

Uh oh!

DaanHoogland commented Apr 17, 2025

Uh oh!

blueorangutan commented Apr 17, 2025

Uh oh!

blueorangutan commented Apr 17, 2025

Uh oh!

Pearl1594 commented Apr 18, 2025

Uh oh!

blueorangutan commented Apr 18, 2025

Uh oh!

Pearl1594 commented Apr 18, 2025

Uh oh!

blueorangutan commented Apr 18, 2025

Uh oh!

blueorangutan commented Apr 18, 2025

Uh oh!

blueorangutan commented Apr 18, 2025

Uh oh!

Pearl1594 commented Apr 21, 2025

Uh oh!

blueorangutan commented Apr 21, 2025

Uh oh!

blueorangutan commented Apr 22, 2025

Uh oh!

Pearl1594 commented Apr 22, 2025

Uh oh!

Pearl1594 commented Apr 22, 2025

Uh oh!

blueorangutan commented Apr 22, 2025

Uh oh!

sonarqubecloud bot commented Apr 22, 2025

Quality Gate passed

Uh oh!

blueorangutan commented Apr 22, 2025

Uh oh!

Pearl1594 commented Apr 22, 2025

Uh oh!

blueorangutan commented Apr 22, 2025

codecov bot commented Apr 16, 2025 •

edited

Loading