UI: Add option to Login to a specific Project view via setting on config.json #10935
Conversation
nvazquez
requested review from
DaanHoogland,
GutoVeronezi,
JoaoJandre,
Pearl1594 and
rohityadavcloud
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10935 +/- ##
=========================================
Coverage 16.60% 16.60%
+ Complexity 13925 13924 -1
=========================================
Files 5729 5729
Lines 508070 508083 +13
Branches 61769 61771 +2
=========================================
+ Hits 84370 84373 +3
- Misses 414271 414282 +11
+ Partials 9429 9428 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, tested in QA
|
Probably not a good idea? Instead this could be an account level setting, why do we want this? |
I don’t understand you remark @rohityadavcloud , an account can participate in tons of projects and may want to log into a specific one from the start. Admitted it is a bit of candy, but why not a good idea? |
|
Sorry @rohityadavcloud why is it not good idea? In my point of view it improves usability on the UI but not seeing the downside |
|
I don't think this is a good UX/design - most users won't remember their project names. At least most shouldn't want to see this by default, could we wrap in some UI config i.e. disabled by default? Also check the 2FA UI, this could potentially break when 2FA is enabled. |
|
Thanks @rohityadavcloud - I have refactored the PR to be optional and disabled by default. Admins have to toggle a key on the |
nvazquez
changed the title
|
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13693 |
There was a problem hiding this comment.
Sorry @nvazquez
-1 this is just really bad UX. In most environments, this isn't possible as people need to remember the project name/details. This shouldn't be on the login screen.
That said, +0 as you've made it configurable via config.json so this isn't the default and someone needs to explicitly enable this.
kiranchavala
left a comment
kiranchavala
left a comment
There was a problem hiding this comment.
LGTM, Tested manually
-
Enabled "displayProjectFieldOnLogin" in /etc/cloudstack/management/config.json
-
Check the login screen and the project box is displayed
-
Login as admin user and create some projects
-
Add account to the project
-
Login by providing the project details
github-project-automation
bot
moved this from In Progress
to Done
in Apache CloudStack 4.21.0
…fig.json (apache#10935) * UI: Login to a specific Project view * Fix project icon * Add the option to display project on login on the config.json file --------- Co-authored-by: Pearl Dsilva <[email protected]>
6 participants
Description
This PR adds a new setting on the
config.jsonfile:displayProjectFieldOnLogin- false by default to preserve the current behavior.Documentation PR: apache/cloudstack-documentation#515
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?