Skip to content

Fix data being replicated on VM's metadata file in VR #10987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 1 commit into from
Jun 13, 2025
Merged

Fix data being replicated on VM's metadata file in VR #10987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions systemvm/debian/opt/cloud/bin/configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,6 +908,7 @@ def __createfile(self, ip, folder, file, data):
if os.path.exists(metamanifest):
fh = open(metamanifest, "a+")
self.__exflock(fh)
fh.seek(0)
Comment on lines 909 to +911
Copy link
Contributor

@DaanHoogland DaanHoogland Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GutoVeronezi , I think your intention is

Suggested change
fh = open(metamanifest, "a+")
self.__exflock(fh)
fh.seek(0)
fh = open(metamanifest, “w+")
self.__exflock(fh)

opeing with a+ will not truncate the previous version, but only overwrite data afaik.

Copy link
Contributor Author

@GutoVeronezi GutoVeronezi Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a is for appending; + is for allow reading, however, the pointer must be set to 0 to the validation work properly. w would overwrite the data. This is the same as #10254

Copy link
Contributor

@DaanHoogland DaanHoogland Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, I missed the fh.read() on the next line

if file not in fh.read():
fh.write(file + '\n')
self.__unflock(fh)
Expand Down
Loading