Skip to content

.github: Update to JDK 17 in ci.yml and build.yml #11030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weizhouapache merged 4 commits into from
Sep 1, 2025
Merged

.github: Update to JDK 17 in ci.yml and build.yml #11030

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17e1e0c
.github: Update to JDK 17 in build.yml
weizhouapache Jun 11, 2025
d7dae8d
.github: update JDK in ci.yml
weizhouapache Jun 16, 2025
580533f
Merge branch 'main' into 4.21-gha-jdk17-build
sureshanaparti Jul 15, 2025
705afae
Merge branch 'main' into 4.21-gha-jdk17-build
weizhouapache Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,12 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v4
with:
java-version: '11'
distribution: 'adopt'
architecture: x64
cache: maven
distribution: 'temurin'
java-version: '17'
cache: 'maven'

- name: Set up Python
uses: actions/setup-python@v5
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,13 +216,12 @@ jobs:
with:
fetch-depth: 0

- name: Set up JDK
- name: Set up JDK 17
uses: actions/setup-java@v4
with:
java-version: '11'
distribution: 'adopt'
architecture: x64
cache: maven
distribution: 'temurin'
java-version: '17'
cache: 'maven'

- name: Set up Python
uses: actions/setup-python@v5
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
<cs.jdk.version>11</cs.jdk.version>
Copy link

Copilot AI Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <cs.jdk.version> property is still set to 11 but workflows now use JDK 17. Update this to <cs.jdk.version>17</cs.jdk.version> for consistency.

Suggested change
<cs.jdk.version>11</cs.jdk.version>
<cs.jdk.version>17</cs.jdk.version>

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@DaanHoogland DaanHoogland Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one actually makes sense, does it @weizhouapache ?

Copy link
Member Author

@weizhouapache weizhouapache Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaanHoogland

It will drop the support of jdk11.
I think it is better to change it when we work on jdk21 support

<cs.target.dir>target</cs.target.dir>
<cs.replace.properties>build/replace.properties</cs.replace.properties>
<argLine>-Djava.security.egd=file:/dev/./urandom -noverify --add-opens=java.base/java.lang=ALL-UNNAMED --add-exports=java.base/sun.security.x509=ALL-UNNAMED --add-opens=java.base/javax.net.ssl=ALL-UNNAMED</argLine>
<argLine>-Djava.security.egd=file:/dev/./urandom -noverify --add-opens=java.base/java.lang=ALL-UNNAMED --add-exports=java.base/sun.security.x509=ALL-UNNAMED --add-exports=java.base/sun.security.provider=ALL-UNNAMED --add-opens=java.base/javax.net.ssl=ALL-UNNAMED</argLine>

<!-- Plugins versions -->
<cs.antrun-plugin.version>1.8</cs.antrun-plugin.version>
Expand Down
Loading