Skip to content

Conversation

@jbampton
Copy link
Member

Authors are encouraged to omit the type attribute. And the language attribute was never standardized and should not be used.

We use lowercase for HTML so made the doctype lowercase as well to be consistent.

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script/type

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script#language

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Authors are encouraged to omit the type attribute.  And the language attribute was never standardized and should not be used.

We use lowercase for HTML so made the doctype lowercase as well to be consistent.

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script/type

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script#language
@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13877

@DaanHoogland
Copy link
Contributor

@blueorangutan LLtest keepEnv

@blueorangutan
Copy link

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@github-actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.74%. Comparing base (d63899f) to head (6950229).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##              main   #11067       +/-   ##
============================================
+ Coverage     3.89%   16.74%   +12.84%     
- Complexity       0    14062    +14062     
============================================
  Files          417     5724     +5307     
  Lines        33973   507787   +473814     
  Branches      6096    61733    +55637     
============================================
+ Hits          1324    85038    +83714     
- Misses       32491   413266   +380775     
- Partials       158     9483     +9325     
Flag Coverage Δ
uitests 3.89% <ø> (ø)
unittests 17.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@vishesh92 vishesh92 requested a review from Copilot July 23, 2025 11:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes HTML code across the project by modernizing HTML element attributes and fixing HTML license comment format. The changes align with current HTML best practices by removing deprecated attributes and using lowercase doctype declarations.

  • Updated DOCTYPE declarations from uppercase to lowercase for consistency
  • Removed deprecated type="text/javascript" and language attributes from script tags
  • Fixed HTML license header format in one template file

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ui/public/index.html Changed DOCTYPE to lowercase
ui/public/example.html Changed DOCTYPE to lowercase
tools/ngui/templates/index.html Fixed license header format and updated DOCTYPE and script attributes
tools/apidoc/generatecommands.xsl Removed type attribute from script tag
systemvm/agent/ui/viewer.ftl Removed type and language attributes from script tags
systemvm/agent/noVNC/vnc_lite.html Changed DOCTYPE to lowercase
systemvm/agent/noVNC/vnc.html Changed DOCTYPE to lowercase

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert the changes for noVNC? This is a clone from https://github.com/novnc/noVNC/ and it would be better to keep this as close to the original source code.

https://developer.mozilla.org/en-US/docs/Glossary/Doctype

The doctype is case-insensitive. The convention of MDN code examples is to use lowercase, but it's also common to write it as <!DOCTYPE html>.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14313

@DaanHoogland
Copy link
Contributor

checked debian build in the background ; works

@DaanHoogland DaanHoogland merged commit 165ab0a into apache:main Jul 23, 2025
26 checks passed
@jbampton jbampton deleted the modernize-html-code branch July 23, 2025 15:49
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants