fix fsvm-init.yml to detect virtio-scsi in kvm

[levindecaro]

Description

This PR about the sharedFS VM not functional while systemvm has been configured to use scsi as rootDiskController, this change added controller detection logic during init state.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested on OL9 KVM configuration for systemvm with rootDiskController=scsi configuration

How did you try to break this feature and the system with this change?

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

• In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
• Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
• Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
• Be sure to read the CloudStack Coding Conventions.
  Apache CloudStack is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: [email protected] (https://cloudstack.apache.org/mailing-lists.html)
  Slack: https://apachecloudstack.slack.com/

[abh1sar]

Thanks for working on this. One minor comment.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.57%. Comparing base (5b7c3b4) to head (8bb8e86).
⚠️ Report is 141 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11070   +/-   ##
=========================================
  Coverage     16.57%   16.57%           
  Complexity    13967    13967           
=========================================
  Files          5743     5743           
  Lines        510468   510468           
  Branches      62073    62073           
=========================================
  Hits          84616    84616           
  Misses       416390   416390           
  Partials       9462     9462           

Flag	Coverage Δ
uitests	3.90% <ø> (ø)
unittests	17.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[abh1sar]

@blueorangutan package

[blueorangutan]

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13906

[abh1sar]

Tested on KVM and VMWare with virtio disk. LGTM.

[abh1sar]

@blueorangutan test

[blueorangutan]

@abh1sar a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13742)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57355 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11070-t13742-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

clgtm

[DaanHoogland]

@blueorangutan test ol9 vmware-70u3

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol9 mgmt + vmware-70u3) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13749)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 93728 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11070-t13749-vmware-70u3.zip
Smoke tests completed. 129 look OK, 12 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_prepare_and_cancel_maintenance	Error	0.19	test_ms_maintenance_and_safe_shutdown.py
test_nic_secondaryip_add_remove	Error	1516.47	test_multipleips_per_nic.py
ContextSuite context=TestNestedVirtualization>:setup	Error	0.00	test_nested_virtualization.py
ContextSuite context=TestNetworkACL>:setup	Error	0.00	test_network_acl.py
ContextSuite context=TestIpv6Network>:setup	Error	0.00	test_network_ipv6.py
test_delete_account	Error	1515.89	test_network.py
test_delete_network_while_vm_on_it	Error	1.18	test_network.py
test_deploy_vm_l2network	Error	1.17	test_network.py
test_l2network_restart	Error	2.29	test_network.py
ContextSuite context=TestPortForwarding>:setup	Error	3.50	test_network.py
ContextSuite context=TestPublicIP>:setup	Error	9.58	test_network.py
test_reboot_router	Failure	0.07	test_network.py
test_releaseIP	Error	4.91	test_network.py
test_releaseIP_using_IP	Error	5.07	test_network.py
ContextSuite context=TestRouterRules>:setup	Error	5.15	test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	Error	1522.24	test_network.py
ContextSuite context=TestPrivateGwACL>:setup	Error	0.00	test_privategw_acl.py
ContextSuite context=TestAdapterTypeForNic>:setup	Error	0.00	test_nic_adapter_type.py
ContextSuite context=TestNonStrictAffinityGroups>:setup	Error	0.00	test_nonstrict_affinity_group.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	Error	0.00	test_password_server.py
ContextSuite context=TestPortForwardingRules>:setup	Error	0.00	test_portforwardingrules.py
ContextSuite context=TestProjectSuspendActivate>:setup	Error	1528.54	test_projects.py

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14477

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[boring-cyborg]

Awesome work, congrats on your first merged pull request!

[blueorangutan]

[SF] Trillian test result (tid-13979)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 82114 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11070-t13979-kvm-ol8.zip
Smoke tests completed. 137 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestRemoteDiagnostics>:setup	Error	0.00	test_diagnostics.py
ContextSuite context=TestAccounts>:setup	Error	0.00	test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup	Error	0.00	test_accounts.py
test_DeleteDomain	Error	14.19	test_accounts.py
test_forceDeleteDomain	Failure	14.31	test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup	Error	14.21	test_accounts.py
ContextSuite context=TestTemplateHierarchy>:setup	Error	1534.02	test_accounts.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup	Error	0.00	test_affinity_groups_projects.py
ContextSuite context=TestAnnotations>:setup	Error	0.00	test_annotations.py
ContextSuite context=TestDeployVMFromISO>:setup	Error	0.00	test_deploy_vm_iso.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup	Error	0.00	test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestDomainsServiceOfferings>:setup	Error	1520.10	test_domain_service_offerings.py
test_01_deployVMInSharedNetwork	Failure	363.28	test_network.py