Skip to content

Conversation

@slavkap
Copy link
Contributor

@slavkap slavkap commented Jun 30, 2025

Description

This PR refactors StorPool's smoke tests

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

How did you try to break this feature and the system with this change?

Executed all tests on the latest main branch

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Jun 30, 2025
@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.17%. Comparing base (16c60c7) to head (0db0137).
⚠️ Report is 146 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11107      +/-   ##
============================================
+ Coverage     16.57%   17.17%   +0.60%     
- Complexity    13968    15010    +1042     
============================================
  Files          5743     5869     +126     
  Lines        510494   521710   +11216     
  Branches      62075    63509    +1434     
============================================
+ Hits          84617    89614    +4997     
- Misses       416415   422039    +5624     
- Partials       9462    10057     +595     
Flag Coverage Δ
uitests 3.76% <ø> (-0.15%) ⬇️
unittests 18.15% <ø> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti
Copy link
Contributor

@slavkap can you check the license / lint errors.

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14476

@sureshanaparti
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, and we need to trust @slavkap on this

@sureshanaparti sureshanaparti merged commit 5aa1518 into apache:main Jul 31, 2025
25 of 26 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Jul 31, 2025
@blueorangutan
Copy link

[SF] Trillian test result (tid-13978)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 84617 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11107-t13978-kvm-ol8.zip
Smoke tests completed. 138 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestAccounts>:setup Error 0.00 test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup Error 0.00 test_accounts.py
test_DeleteDomain Error 13.83 test_accounts.py
test_forceDeleteDomain Failure 14.12 test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup Error 14.85 test_accounts.py
ContextSuite context=TestTemplateHierarchy>:setup Error 1535.84 test_accounts.py
ContextSuite context=TestDeployVMsInParallel>:setup Error 0.00 test_deploy_vms_in_parallel.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup Error 0.00 test_affinity_groups_projects.py
ContextSuite context=TestAnnotations>:setup Error 0.00 test_annotations.py
ContextSuite context=TestDeployVmWithUserData>:setup Error 0.00 test_deploy_vm_with_userdata.py
ContextSuite context=TestAsyncJob>:setup Error 0.00 test_async_job.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup Error 0.00 test_deploy_vms_with_varied_deploymentplanners.py

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025
* Refactor StorPool  smoke tests

* Marvin confing template for StorPool tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants