-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ui: fix initial pagination for images in deploy forms #11349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: fix initial pagination for images in deploy forms #11349
Conversation
Regression from apache#10773 Signed-off-by: Abhishek Kumar <[email protected]>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11349 +/- ##
=========================================
Coverage 17.17% 17.17%
- Complexity 14993 14994 +1
=========================================
Files 5869 5869
Lines 521728 521728
Branches 63506 63506
=========================================
+ Hits 89604 89606 +2
+ Misses 422053 422052 -1
+ Partials 10071 10070 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
UI build: ✔️ |
Regression from apache#10773 Signed-off-by: Abhishek Kumar <[email protected]>
Description
Regression from #10773
All templates for a category are getting listed initially. This PR fixes by adding pagination correctly
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?