[UI] Use GET request method for list API calls #11354

sureshanaparti · 2025-07-30T16:52:41Z

Description

This PR updates UI to use GET request method for list API calls.

Earlier some API calls (in generic methods) from UI are using POST request method for the list calls, added here: #10899. This PR updates these call to use the GET request method.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Verified the request method (in browser's inspect window) of some list API calls from the CloudStack UI.

How did you try to break this feature and the system with this change?

sureshanaparti · 2025-07-30T16:53:02Z

@blueorangutan ui

blueorangutan · 2025-07-30T16:54:04Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-07-30T17:12:53Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11354 (QA-JID-707)

nvazquez · 2025-07-30T17:30:47Z

ui/src/api/index.js

 } from '@/store/mutation-types'

+const getAPICommandsRegex = /^(get|list|query|find)\w+$/i
+const addlGetAPICommandsList = [


Suggested change

const addlGetAPICommandsList = [

const addGetAPICommandsList = [

sry, it's for additional get api list, will update to otherGetAPICommandsList, fine @nvazquez ?

Ahh sure @sureshanaparti, I thought it was a typo 👍🏼

Or maybe also: additionalGetAPICommandsList

@sureshanaparti could you please explain how did we get this list of additional APIs?

@Pearl1594 all these additional APIs are the read calls from DB or the configuration (added regex for regular list/get cmds, these doesn't match with regular list, so, added them as additional). I've checked the execute() calls of these API cmds while working on this - #10899.

ui/src/api/index.js

codecov · 2025-07-30T17:48:17Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.17%. Comparing base (7124922) to head (6808cc3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##              main   #11354       +/-   ##
============================================
+ Coverage     3.76%   17.17%   +13.41%     
- Complexity       0    15007    +15007     
============================================
  Files          436     5869     +5433     
  Lines        35575   521737   +486162     
  Branches      6455    63511    +57056     
============================================
+ Hits          1338    89609    +88271     
- Misses       34077   422071   +387994     
- Partials       160    10057     +9897

Flag	Coverage Δ
uitests	`3.77% <ø> (+0.01%)`	⬆️
unittests	`18.15% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti · 2025-07-30T17:49:53Z

@blueorangutan ui

Pearl1594 · 2025-07-30T18:13:47Z

code lgtm - just have a query regarding the list of additional APIs.

sureshanaparti · 2025-07-30T18:51:29Z

@blueorangutan ui

blueorangutan · 2025-07-30T18:52:04Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-07-30T19:09:14Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11354 (QA-JID-709)

nvazquez

LGTM

sureshanaparti · 2025-07-31T04:31:10Z

@blueorangutan package

blueorangutan · 2025-07-31T04:32:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-31T05:50:42Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14482

kiranchavala

LGTM, Tested manually by checking the deploy vm form

Before fix, the api calls like list hosts, list service offerings list disk offerings were POST

After fix , the api calls are GET

* [UI] Use GET request method for list API calls * Updated UI unit tests

boring-cyborg bot added the component:UI label Jul 30, 2025

sureshanaparti added this to the 4.21.0 milestone Jul 30, 2025

sureshanaparti added this to Apache CloudStack 4.21.0 Jul 30, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jul 30, 2025

sureshanaparti requested review from DaanHoogland, Pearl1594, nvazquez and shwstppr July 30, 2025 17:16

nvazquez reviewed Jul 30, 2025

View reviewed changes

nvazquez approved these changes Jul 30, 2025

View reviewed changes

sureshanaparti added 2 commits July 31, 2025 10:05

[UI] Use GET request method for list API calls

ed6d6b0

review comments

d4f2bbd

sureshanaparti force-pushed the ui-get-request-method-for-list-calls branch from 790baa1 to d4f2bbd Compare July 31, 2025 04:37

Updated UI unit tests

6808cc3

kiranchavala approved these changes Jul 31, 2025

View reviewed changes

sureshanaparti merged commit f58372e into apache:main Jul 31, 2025
23 of 26 checks passed

github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Jul 31, 2025

DaanHoogland deleted the ui-get-request-method-for-list-calls branch July 31, 2025 10:04

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025

[UI] Use GET request method for list API calls (apache#11354)

5b9d802

* [UI] Use GET request method for list API calls * Updated UI unit tests

	const addlGetAPICommandsList = [
	const addGetAPICommandsList = [

[UI] Use GET request method for list API calls #11354

[UI] Use GET request method for list API calls #11354

Uh oh!

Conversation

sureshanaparti commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

nvazquez Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nvazquez Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

nvazquez Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

Pearl1594 Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti commented Jul 30, 2025

Uh oh!

Pearl1594 commented Jul 30, 2025

Uh oh!

sureshanaparti commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

blueorangutan commented Jul 30, 2025

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Jul 31, 2025

Uh oh!

blueorangutan commented Jul 31, 2025

Uh oh!

blueorangutan commented Jul 31, 2025

Uh oh!

kiranchavala left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

sureshanaparti commented Jul 30, 2025 •

edited

Loading

sureshanaparti Jul 30, 2025 •

edited

Loading

sureshanaparti Jul 30, 2025 •

edited

Loading

codecov bot commented Jul 30, 2025 •

edited

Loading

kiranchavala left a comment •

edited

Loading