Skip to content

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Aug 14, 2025

Description

This PR fixes an issue when restore snapshot in external provider Proxmox

Steps to reproduce the issue

image

Reason:

  • snapshot-002 does not have memory, the vm is stopped when restore snapshot-002, starting worked
  • snapshot-001 has memory, the vm is still running when restore snapshot-001, starting failed. No need to start

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.36%. Comparing base (9fd2b90) to head (4ddb124).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11450   +/-   ##
=========================================
  Coverage     17.36%   17.36%           
+ Complexity    15236    15235    -1     
=========================================
  Files          5886     5886           
  Lines        525645   525645           
  Branches      64156    64156           
=========================================
  Hits          91257    91257           
  Misses       424093   424093           
  Partials      10295    10295           
Flag Coverage Δ
uitests 3.63% <ø> (ø)
unittests 18.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14627

Copy link
Contributor

@vladimirpetrov vladimirpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on manual testing!

@weizhouapache weizhouapache marked this pull request as ready for review August 15, 2025 13:51
@sureshanaparti sureshanaparti added this to the 4.21.0 milestone Aug 15, 2025
@sureshanaparti sureshanaparti merged commit 93d6ff3 into apache:main Aug 15, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Aug 15, 2025
@DaanHoogland DaanHoogland deleted the 4.21-proxmox-restore-snapshot-with-memory branch August 15, 2025 14:42
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants