Fix for PowerFlex MDM configuration on host while preparing the SDC connection

[sureshanaparti]

Description

This PR fixes the PowerFlex MDM configuration on host while preparing the SDC connection.

PowerFlex improvements code (for adding MDMs) is missing from the PRs: #11047, #9903

Fixes #11456

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Deployed instance on PowerFlex storage, with the config 'powerflex.connect.on.demand' enabled. Noticed PowerFlex MDMs are auto configured in the KVM hosts.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.35%. Comparing base (ba2d70a) to head (e78f4ef).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../hypervisor/kvm/storage/ScaleIOStorageAdaptor.java	20.00%	10 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11458      +/-   ##
============================================
- Coverage     17.36%   17.35%   -0.01%     
+ Complexity    15239    15232       -7     
============================================
  Files          5886     5886              
  Lines        525661   525669       +8     
  Branches      64155    64158       +3     
============================================
- Hits          91267    91254      -13     
- Misses       424099   424115      +16     
- Partials      10295    10300       +5     

Flag	Coverage Δ
uitests	3.63% <ø> (ø)
unittests	18.39% <20.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14642

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14644

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[DaanHoogland]

@sureshanaparti , why remove the unit-tests for prepareStorageClient(…), I’d say we need to add unit tests to prevent such a regression from happening again, not remove any.

[sureshanaparti]

@sureshanaparti , why remove the unit-tests for prepareStorageClient(…), I’d say we need to add unit tests to prevent such a regression from happening again, not remove any.

@DaanHoogland these unit tests are not needed, prepare SDC behavior changed in main/4.21 (these unit tests are already removed here: https://github.com/apache/cloudstack/pull/9903/files#diff-fedce0e754eac19caeff61ea3003c2aef3cca165fec084981a07c06ae3342919)

[blueorangutan]

[SF] Trillian test result (tid-14070)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57783 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11458-t14070-kvm-ol8.zip
Smoke tests completed. 135 look OK, 11 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDeployVirtioSCSIVM>:setup	Error	0.00	test_deploy_virtio_scsi_vm.py
test_08_arping_in_ssvm	Failure	5.22	test_diagnostics.py
test_13_retrieve_vr_default_files	Error	1.13	test_diagnostics.py
test_14_retrieve_vr_one_file	Error	1.12	test_diagnostics.py
test_15_retrieve_ssvm_default_files	Error	1.13	test_diagnostics.py
test_16_retrieve_ssvm_single_file	Error	1.13	test_diagnostics.py
test_17_retrieve_cpvm_default_files	Error	1.14	test_diagnostics.py
test_18_retrieve_cpvm_single_file	Error	1.14	test_diagnostics.py
test_01_invalid_upgrade_kubernetes_cluster	Failure	0.01	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	Failure	0.01	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	0.01	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	Failure	0.01	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	Failure	0.01	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	Failure	0.01	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	0.01	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	Failure	0.01	test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle	Error	0.01	test_kubernetes_clusters.py
test_12_test_deploy_cluster_different_offerings_per_node_type	Failure	0.01	test_kubernetes_clusters.py
test_01_native_to_native_network_migration	Error	14.71	test_migration.py
test_02_native_to_native_vpc_migration	Error	13.48	test_migration.py
test_nic_secondaryip_add_remove	Error	22.62	test_multipleips_per_nic.py
test_network_acl	Error	8.52	test_network_acl.py
test_01_verify_ipv6_network	Error	3.15	test_network_ipv6.py
test_01_verify_ipv6_network	Error	3.15	test_network_ipv6.py
test_03_network_operations_on_created_vm_of_otheruser	Error	2.63	test_network_permissions.py
test_03_network_operations_on_created_vm_of_otheruser	Error	2.63	test_network_permissions.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	Failure	1.45	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	Error	1.52	test_network_permissions.py
test_delete_account	Error	23.14	test_network.py
test_delete_network_while_vm_on_it	Error	2.45	test_network.py
test_delete_network_while_vm_on_it	Error	2.45	test_network.py
test_deploy_vm_l2network	Error	2.46	test_network.py
test_deploy_vm_l2network	Error	2.46	test_network.py
test_l2network_restart	Error	3.59	test_network.py
test_l2network_restart	Error	3.59	test_network.py
ContextSuite context=TestL2Networks>:teardown	Error	4.71	test_network.py
test_09_list_templates_download_details	Failure	0.09	test_templates.py
test_deploy_vm_multiple	Error	12.51	test_vm_life_cycle.py
test_01_migrate_VM_and_root_volume	Error	1.39	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	1.32	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	Error	150.22	test_vm_life_cycle.py
test_10_attachAndDetach_iso	Error	12.48	test_vm_life_cycle.py

[harikrishna-patnala]

code LGTM