-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ui: show multiple domains as links in list view #11536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently, when resources are linked to multiple domains and they are shown in the list view, they are not clickable. This PR fixes it. Signed-off-by: Abhishek Kumar <[email protected]>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11536 +/- ##
============================================
+ Coverage 16.16% 16.17% +0.01%
- Complexity 13279 13287 +8
============================================
Files 5656 5656
Lines 497884 498008 +124
Branches 60378 60404 +26
============================================
+ Hits 80463 80539 +76
- Misses 408466 408506 +40
- Partials 8955 8963 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
Signed-off-by: Abhishek Kumar <[email protected]>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
PR looks good to me. However, shouldn't we have waited for one additional approval before merging it? |
oh, I did not notice it |
* ui: show multiple domains as links in list view Currently, when resources are linked to multiple domains and they are shown in the list view, they are not clickable. This PR fixes it. Signed-off-by: Abhishek Kumar <[email protected]> * fix Signed-off-by: Abhishek Kumar <[email protected]> --------- Signed-off-by: Abhishek Kumar <[email protected]>

Description
Currently, when resources are linked to multiple domains and they are shown in the list view, they are not clickable. This PR fixes it.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before:

After:

How Has This Been Tested?
How did you try to break this feature and the system with this change?