Skip to content

Conversation

@vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Sep 1, 2025

Description

This PR adds support for building EL10 compatible packages and also adds support for Java 21 for EL10 packages.

Doc PR: apache/cloudstack-documentation#557

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for building EL10 (Enterprise Linux 10) compatible packages by creating a symbolic link from el10 to el8 packaging configuration and updating the EL8 spec file to support newer Java versions and system dependencies.

  • Creates a symbolic link structure to reuse EL8 packaging for EL10
  • Updates Java dependencies to include Java 21 support alongside existing Java 11/17
  • Adds compatibility for newer system libraries and utilities in EL10

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packaging/el8/cloud.spec Updates dependencies and exclusions to support EL10 compatibility
packaging/el10 Creates symbolic link to reuse EL8 packaging configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.36%. Comparing base (574ed78) to head (e03fa85).
⚠️ Report is 80 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11546   +/-   ##
=========================================
  Coverage     17.36%   17.36%           
  Complexity    15237    15237           
=========================================
  Files          5888     5888           
  Lines        525737   525737           
  Branches      64164    64164           
=========================================
  Hits          91274    91274           
  Misses       424163   424163           
  Partials      10300    10300           
Flag Coverage Δ
uitests 3.63% <ø> (ø)
unittests 18.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vishesh92 vishesh92 changed the title Add support EL10 Add support EL10 & support java 21 for EL10 Sep 1, 2025
@vishesh92 vishesh92 force-pushed the add-support-for-el10 branch from a377df8 to e77c4b4 Compare September 1, 2025 12:06
@vishesh92 vishesh92 force-pushed the add-support-for-el10 branch from e77c4b4 to e03fa85 Compare September 1, 2025 12:08
@vishesh92
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14806

@apache apache deleted a comment from blueorangutan Sep 2, 2025
@apache apache deleted a comment from blueorangutan Sep 2, 2025
@apache apache deleted a comment from blueorangutan Sep 2, 2025
@apache apache deleted a comment from blueorangutan Sep 2, 2025
@apache apache deleted a comment from blueorangutan Sep 2, 2025
@harikrishna-patnala harikrishna-patnala added this to the 4.22.0 milestone Sep 2, 2025
@apache apache deleted a comment from blueorangutan Sep 2, 2025
@blueorangutan
Copy link

[SF] Trillian test result (tid-14174)
Environment: kvm-alma10 (x2), zone: Advanced Networking with Mgmt server a10
Total time taken: 54169 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11546-t14174-kvm-alma10.zip
Smoke tests completed. 144 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_deploy_vm_from_iso_uefi_legacy Error 13.73 test_deploy_vm_iso_uefi.py
test_03_deploy_windows_vm_from_iso_uefi_legacy Error 16.73 test_deploy_vm_iso_uefi.py
test_04_rvpc_network_garbage_collector_nics Failure 1461.62 test_vpc_redundant.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-14172)
Environment: kvm-ol10 (x2), zone: Advanced Networking with Mgmt server ol10
Total time taken: 56446 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11546-t14172-kvm-ol10.zip
Smoke tests completed. 145 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_04_rvpc_network_garbage_collector_nics Failure 1477.55 test_vpc_redundant.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-14173)
Environment: kvm-rocky10 (x2), zone: Advanced Networking with Mgmt server r10
Total time taken: 57954 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11546-t14173-kvm-rocky10.zip
Smoke tests completed. 144 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_04_rvpc_network_garbage_collector_nics Failure 1471.82 test_vpc_redundant.py
test_01_vpc_site2site_vpn_multiple_options Error 694.07 test_vpc_vpn.py

Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apache apache deleted a comment from blueorangutan Sep 10, 2025
@apache apache deleted a comment from blueorangutan Sep 10, 2025
@apache apache deleted a comment from blueorangutan Sep 10, 2025
@apache apache deleted a comment from blueorangutan Sep 11, 2025
@apache apache deleted a comment from blueorangutan Sep 11, 2025
@apache apache deleted a comment from blueorangutan Sep 11, 2025
@blueorangutan
Copy link

[SF] Trillian test result (tid-14288)
Environment: kvm-suse15 (x2), zone: Advanced Networking with Mgmt server s15
Total time taken: 43395 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11546-t14288-kvm-suse15.zip
Smoke tests completed. 107 look OK, 39 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Failure 0.02 test_events_resource.py
ContextSuite context=TestTemplateHierarchy>:setup Error 11.13 test_accounts.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup Error 0.00 test_affinity_groups.py
ContextSuite context=TestDeployVmRootSize>:setup Error 0.00 test_deploy_vm_root_resize.py
ContextSuite context=TestMultipleVolumeAttach>:setup Error 0.00 test_attach_multiple_volumes.py
ContextSuite context=TestDummyBackupAndRecovery>:setup Error 0.00 test_backup_recovery_dummy.py
ContextSuite context=TestNASBackupAndRecovery>:setup Error 0.00 test_backup_recovery_nas.py
ContextSuite context=TestVeeamBackupAndRecovery>:setup Error 0.00 test_backup_recovery_veeam.py
ContextSuite context=TestConsoleEndpoint>:setup Error 0.00 test_console_endpoint.py
test_01_deploy_vm_with_extraconfig_throws_exception_kvm Error 0.10 test_deploy_vm_extra_config_data.py
test_02_deploy_vm_with_extraconfig_kvm Error 0.06 test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvm Error 0.06 test_deploy_vm_extra_config_data.py
ContextSuite context=TestHostControlState>:setup Error 47.88 test_host_control_state.py
ContextSuite context=TestImportAndUnmanageVolumes>:setup Error 0.00 test_import_unmanage_volumes.py
test_01_invalid_upgrade_kubernetes_cluster Failure 57.75 test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster Failure 61.92 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 65.93 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 62.87 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 61.76 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 61.96 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 59.79 test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster Failure 78.33 test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle Error 3.30 test_kubernetes_clusters.py
test_12_test_deploy_cluster_different_offerings_per_node_type Failure 66.02 test_kubernetes_clusters.py
ContextSuite context=TestListVolumes>:setup Error 0.00 test_list_volumes.py
test_list_management_server_metrics Failure 0.21 test_metrics_api.py
ContextSuite context=TestNetworkMigration>:setup Error 0.00 test_migration.py
test_03_network_operations_on_created_vm_of_otheruser Error 1.22 test_network_permissions.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Failure 0.05 test_network_permissions.py
ContextSuite context=TestSharedNetwork>:setup Error 50.92 test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1565.53 test_network.py
test_01_nic Error 0.06 test_nic.py
ContextSuite context=TestL2PersistentNetworks>:setup Error 0.00 test_persistent_network.py
test_01_add_primary_storage_disabled_host Failure 0.07 test_primary_storage.py
test_01_primary_storage_iscsi Failure 0.06 test_primary_storage.py
test_01_primary_storage_nfs Failure 0.06 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.14 test_primary_storage.py
ContextSuite context=TestPrivateGwACLOvsGRE>:setup Error 0.00 test_privategw_acl_ovs_gre.py
ContextSuite context=TestPurgeExpungedVms>:setup Error 0.00 test_purge_expunged_vms.py
ContextSuite context=TestResourceNames>:setup Error 0.00 test_resource_names.py
ContextSuite context=TestSharedFSLifecycle>:setup Error 0.00 test_sharedfs_lifecycle.py
ContextSuite context=TestTemplates>:setup Error 35.83 test_templates.py
test_01_positive_tests_usage Failure 4.06 test_usage_events.py
ContextSuite context=TestLBRuleUsage>:setup Error 2.24 test_usage.py
ContextSuite context=TestNatRuleUsage>:setup Error 2.29 test_usage.py
ContextSuite context=TestPublicIPUsage>:setup Error 2.34 test_usage.py
ContextSuite context=TestSnapshotUsage>:setup Error 2.38 test_usage.py
ContextSuite context=TestTemplateUsage>:setup Error 2.43 test_usage.py
ContextSuite context=TestVmUsage>:setup Error 2.47 test_usage.py
ContextSuite context=TestVolumeUsage>:setup Error 2.55 test_usage.py
ContextSuite context=TestVpnUsage>:setup Error 2.59 test_usage.py
ContextSuite context=TestVMSchedule>:setup Error 0.00 test_vm_schedule.py
ContextSuite context=TestVmAutoScaling>:setup Error 0.00 test_vm_autoscaling.py
test_01_deploy_vm_on_specific_host Error 0.04 test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster Error 0.04 test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod Error 0.07 test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster Error 0.06 test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod Error 0.05 test_vm_deployment_planner.py
ContextSuite context=TestDeployVM>:setup Error 0.00 test_vm_life_cycle.py
ContextSuite context=TestKVMLiveMigration>:setup Error 0.00 test_vm_life_cycle.py
ContextSuite context=TestMigrateVMwithVolume>:setup Error 0.00 test_vm_life_cycle.py
ContextSuite context=TestSecuredVmMigration>:setup Error 0.00 test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup Error 0.05 test_vm_life_cycle.py
ContextSuite context=TestUnmanageVM>:setup Error 0.00 test_vm_lifecycle_unmanage_import.py
ContextSuite context=TestDeployVMFromSnapshotOrVolume>:setup Error 0.00 test_vm_lifecycle_with_snapshot_or_volume.py
ContextSuite context=TestVmSnapshot>:setup Error 0.06 test_vm_snapshots.py
ContextSuite context=TestVnfTemplates>:setup Error 0.00 test_vnf_templates.py
ContextSuite context=TestCreateVolume>:setup Error 0.00 test_volumes.py
ContextSuite context=TestVolumeEncryption>:setup Error 0.00 test_volumes.py
ContextSuite context=TestVolumes>:setup Error 0.00 test_volumes.py
test_04_rvpc_network_garbage_collector_nics Failure 1469.88 test_vpc_redundant.py
test_02_cancel_host_maintenace_with_migration_jobs Failure 0.09 test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure Error 0.18 test_host_maintenance.py
ContextSuite context=TestHostMaintenanceAgents>:setup Error 0.24 test_host_maintenance.py

@vishesh92
Copy link
Member Author

@blueorangutan package

@apache apache deleted a comment from blueorangutan Sep 17, 2025
@apache apache deleted a comment from blueorangutan Sep 17, 2025
@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15056

@blueorangutan
Copy link

[SF] Trillian test result (tid-14370)
Environment: kvm-suse15 (x2), zone: Advanced Networking with Mgmt server s15
Total time taken: 56882 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11546-t14370-kvm-suse15.zip
Smoke tests completed. 145 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_scale_kubernetes_cluster Failure 1.16 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 30.86 test_kubernetes_clusters.py
test_list_management_server_metrics Failure 0.23 test_metrics_api.py

@apache apache deleted a comment from blueorangutan Sep 23, 2025
@vladimirpetrov
Copy link
Contributor

@blueorangutan test suse15 kvm-suse15 keepEnv

@blueorangutan
Copy link

@vladimirpetrov a [SL] Trillian-Jenkins test job (suse15 mgmt + kvm-suse15) has been kicked to run smoke tests

@vladimirpetrov
Copy link
Contributor

@blueorangutan test ol10 kvm-ol10 keepEnv

@blueorangutan
Copy link

@vladimirpetrov a [SL] Trillian-Jenkins test job (ol10 mgmt + kvm-ol10) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-14427)
Environment: kvm-suse15 (x2), zone: Advanced Networking with Mgmt server s15
Total time taken: 57029 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11546-t14427-kvm-suse15.zip
Smoke tests completed. 145 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_scale_kubernetes_cluster Failure 1.13 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 39.06 test_kubernetes_clusters.py
test_list_management_server_metrics Failure 0.21 test_metrics_api.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-14428)
Environment: kvm-ol10 (x2), zone: Advanced Networking with Mgmt server ol10
Total time taken: 56169 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11546-t14428-kvm-ol10.zip
Smoke tests completed. 146 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_scale_kubernetes_cluster Failure 1.19 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 39.12 test_kubernetes_clusters.py

@vishesh92
Copy link
Member Author

@vladimirpetrov for OpenSuse test results, the fix for test_metrics_api.py is already merged and tests seems to be passing as well. (#11670 (comment))

Copy link
Contributor

@vladimirpetrov vladimirpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on manual testing.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohityadavcloud
Copy link
Member

Merging this based on reviews, manual QA and smoketests.

@rohityadavcloud rohityadavcloud merged commit ec533cd into apache:main Sep 25, 2025
26 checks passed
@rohityadavcloud rohityadavcloud deleted the add-support-for-el10 branch September 25, 2025 10:07
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.0 Sep 25, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants