api,server,ui: improve listing public ip for associate #11591

shwstppr · 2025-09-06T08:06:18Z

Description

Currently, acquire or associate IP action in the UI will load only 500 addresses (or whatever defined by config default.page.size). Also, it will load all 500 of them together. This PR uses InfiniteScrollSelect to iteratively load more addresses. To facilitate retrieving both Free and Reserved addresses api and server change has been made for the listPublicIpAddresses API to pass a comma-separated list of states for state parameter.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-09-06T08:14:39Z

Codecov Report

❌ Patch coverage is 64.28571% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (e90e31d) to head (136b6ac).
⚠️ Report is 3 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...in/java/com/cloud/server/ManagementServerImpl.java	62.96%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #11591   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
- Complexity    15538    15544    +6     
=========================================
  Files          5909     5909           
  Lines        529099   529106    +7     
  Branches      64623    64625    +2     
=========================================
+ Hits          92913    92926   +13     
+ Misses       425732   425726    -6     
  Partials      10454    10454

Flag	Coverage Δ
uitests	`3.58% <ø> (+<0.01%)`	⬆️
unittests	`18.63% <64.28%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shwstppr · 2025-09-06T08:22:33Z

@blueorangutan package

blueorangutan · 2025-09-06T08:24:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-06T10:05:31Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14878

DaanHoogland · 2025-09-08T14:10:19Z

@blueorangutan test keepEnv

blueorangutan · 2025-09-08T14:12:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

server/src/main/java/com/cloud/server/ManagementServerImpl.java

Copilot

Pull Request Overview

This pull request enhances the public IP address listing functionality in CloudStack by enabling iterative loading through infinite scroll and supporting multiple states. The primary improvement is in the UI's IP acquisition/association interface, which previously loaded only 500 addresses synchronously.

Key changes include:

Modified listPublicIpAddresses API to accept comma-separated states parameter
Replaced static select component with infinite scroll select in UI
Updated server-side filtering to handle multiple states
Enhanced test coverage for new multi-state functionality

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ui/src/views/network/IpAddressesTab.vue	Replaces static select with InfiniteScrollSelect component and removes manual IP loading logic
ui/src/components/widgets/InfiniteScrollSelect.vue	Adds support for custom label functions and auto-selection of first option
server/src/main/java/com/cloud/server/ManagementServerImpl.java	Implements comma-separated state parameter parsing and multi-state filtering
api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java	Updates API documentation to reflect comma-separated state support
server/src/test/java/com/cloud/server/ManagementServerImplTest.java	Updates test methods to accommodate new multi-state parameter structure

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

ui/src/components/widgets/InfiniteScrollSelect.vue

harikrishna-patnala

code LGTM

harikrishna-patnala · 2025-09-11T05:18:58Z

@blueorangutan package

blueorangutan · 2025-09-11T05:20:03Z

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-11T06:32:26Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14949

DaanHoogland

code looks good, just one remark, no blocker

server/src/main/java/com/cloud/server/ManagementServerImpl.java

github-actions · 2025-10-07T17:17:50Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

shwstppr · 2025-10-07T18:33:26Z

@blueorangutan package

blueorangutan · 2025-10-07T18:34:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-07T19:50:58Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15327

harikrishna-patnala · 2025-10-08T07:53:17Z

ui/src/views/network/IpAddressesTab.vue

+    },
+    listApiParamsForAssociate () {
+      const params = this.listApiParams
+      params.state = 'Free,Reserved'


@shwstppr I tested the changes, it is not listing any IPs now

Seems to be problem with these params

http://10.0.32.194:8080/client/api/?page=1&pagesize=20&zoneid=eb21bc9a-4c08-4456-938b-af605ef36aae&domainid=d3a3e350-a40d-11f0-b82c-1e009c000155&account=admin&forvirtualnetwork=true&allocatedonly=false& state=Free,Reserved &showicon=true&command=listPublicIpAddresses&response=json&sessionkey=fSa-6YW14skm_KeFEJvTnLPpQQs

Thanks for checking @harikrishna-patnala. Will check and fix. Moving to draft for now

@harikrishna-patnala changes should work now

shwstppr · 2025-11-13T12:32:53Z

@blueorangutan package

blueorangutan · 2025-11-13T12:34:05Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-11-13T14:11:45Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15751

remark ignored

DaanHoogland · 2025-11-13T15:11:41Z

server/src/main/java/com/cloud/server/ManagementServerImpl.java

 import org.apache.commons.codec.binary.Base64;
 import org.apache.commons.collections.CollectionUtils;
 import org.apache.commons.collections.MapUtils;
+import org.apache.commons.lang3.EnumUtils;


please let com.cloud.utils.EnumUtils inherit org.apache.commons.lang3.EnumUtils and import that one, to keep related utilities in one place and serve as a proxy in case dependencies need updating/replacing.

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-11-13T19:22:39Z

@blueorangutan package

blueorangutan · 2025-11-13T19:24:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland

this is what I meant. in this case it makes it very simple.

utils/src/main/java/com/cloud/utils/EnumUtils.java

blueorangutan · 2025-11-13T21:01:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15760

Signed-off-by: Abhishek Kumar <[email protected]>

DaanHoogland · 2025-11-14T09:27:03Z

@blueorangutan package

blueorangutan · 2025-11-14T09:28:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-11-14T10:51:39Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15769

DaanHoogland

clgtm, some nitpicking applied

DaanHoogland · 2025-11-14T12:27:34Z

server/src/main/java/com/cloud/server/ManagementServerImpl.java

        Boolean isAllocated = cmd.isAllocatedOnly();
        if (isAllocated == null) {
-            if (state != null && (state.equalsIgnoreCase(IpAddress.State.Free.name()) || state.equalsIgnoreCase(IpAddress.State.Reserved.name()))) {
+            if (states.contains(IpAddress.State.Free) || states.contains(IpAddress.State.Reserved)) {


we cannot have a null here, so no biggy but maybe reverse the checks and even use Arrays?

DaanHoogland · 2025-11-14T12:28:15Z

server/src/main/java/com/cloud/server/ManagementServerImpl.java

            }
        } else {
-            if (state != null && (state.equalsIgnoreCase(IpAddress.State.Free.name()) || state.equalsIgnoreCase(IpAddress.State.Reserved.name()))) {
+            if (states.contains(IpAddress.State.Free) || states.contains(IpAddress.State.Reserved)) {


DaanHoogland · 2025-11-14T12:28:47Z

server/src/main/java/com/cloud/server/ManagementServerImpl.java

                    throw new InvalidParameterValueException("Conflict: allocatedonly is true but state is Free");
                }
-            } else if (state != null && state.equalsIgnoreCase(IpAddress.State.Allocated.name())) {
+            } else if (states.contains(IpAddress.State.Allocated)) {


DaanHoogland · 2025-11-14T12:31:32Z

server/src/main/java/com/cloud/server/ManagementServerImpl.java

-            isAllocatedOrReserved = true;
-        }
+        boolean isAllocatedOrReserved = isAllocated ||
+                (states.size() == 1 && IpAddress.State.Reserved.equals(states.get(0)));


Suggested change

(states.size() == 1 && IpAddress.State.Reserved.equals(states.get(0)));

(states.size() == 1 && states.contains(IpAddress.State.Reserved));

DaanHoogland · 2025-11-14T12:46:17Z

@blueorangutan test keepEnv

blueorangutan · 2025-11-14T12:48:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-11-15T03:33:22Z

[SF] Trillian test result (tid-14835)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50242 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11591-t14835-kvm-ol8.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_1_userdata_on_ssvm	`Error`	3.27	test_systemvm_userdata.py

DaanHoogland · 2025-11-24T15:23:52Z

tested in lab env by defining a 1021 long network range. acquire dialog nicely scrolls through them without preloading.

blueorangutan · 2025-11-25T22:15:40Z

[SF] Trillian test result (tid-14863)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 46359 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11591-t14863-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

boring-cyborg bot added component:api component:management-server component:UI labels Sep 6, 2025

harikrishna-patnala added this to the 4.22.0 milestone Sep 8, 2025

harikrishna-patnala added this to Apache CloudStack 4.22.0 Sep 8, 2025

harikrishna-patnala moved this to In Progress in Apache CloudStack 4.22.0 Sep 8, 2025

harikrishna-patnala reviewed Sep 10, 2025

View reviewed changes

server/src/main/java/com/cloud/server/ManagementServerImpl.java Outdated Show resolved Hide resolved

shwstppr requested a review from Copilot September 10, 2025 09:10

Copilot AI reviewed Sep 10, 2025

View reviewed changes

ui/src/components/widgets/InfiniteScrollSelect.vue Show resolved Hide resolved

ui/src/components/widgets/InfiniteScrollSelect.vue Show resolved Hide resolved

harikrishna-patnala approved these changes Sep 11, 2025

View reviewed changes

DaanHoogland previously approved these changes Sep 15, 2025

View reviewed changes

server/src/main/java/com/cloud/server/ManagementServerImpl.java Outdated Show resolved Hide resolved

github-actions bot added the status:has-conflicts label Oct 7, 2025

github-actions bot removed the status:has-conflicts label Oct 7, 2025

harikrishna-patnala self-requested a review October 8, 2025 07:48

harikrishna-patnala reviewed Oct 8, 2025

View reviewed changes

harikrishna-patnala self-requested a review October 8, 2025 07:54

shwstppr marked this pull request as draft October 9, 2025 12:22

harikrishna-patnala removed this from Apache CloudStack 4.22.0 Nov 12, 2025

shwstppr changed the base branch from main to 4.22 November 13, 2025 12:31

Merge branch '4.22' into improve-publicip-associate

86e8959

DaanHoogland reviewed Nov 13, 2025

View reviewed changes

wrap commons EnumUtils

89eadcb

Signed-off-by: Abhishek Kumar <[email protected]>

apache deleted a comment from blueorangutan Nov 13, 2025

DaanHoogland reviewed Nov 13, 2025

View reviewed changes

utils/src/main/java/com/cloud/utils/EnumUtils.java Outdated Show resolved Hide resolved

utils/src/main/java/com/cloud/utils/EnumUtils.java Outdated Show resolved Hide resolved

change

136b6ac

Signed-off-by: Abhishek Kumar <[email protected]>

DaanHoogland approved these changes Nov 14, 2025

View reviewed changes

apache deleted a comment from blueorangutan Nov 25, 2025

DaanHoogland added the status:waiting-for-smoketest-results label Nov 25, 2025

DaanHoogland removed the status:waiting-for-smoketest-results label Nov 26, 2025

DaanHoogland merged commit 9ec8cc4 into apache:4.22 Nov 26, 2025
26 checks passed

	(states.size() == 1 && IpAddress.State.Reserved.equals(states.get(0)));
	(states.size() == 1 && states.contains(IpAddress.State.Reserved));

api,server,ui: improve listing public ip for associate #11591

api,server,ui: improve listing public ip for associate #11591

Uh oh!

Conversation

shwstppr commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr commented Sep 6, 2025

Uh oh!

blueorangutan commented Sep 6, 2025

Uh oh!

blueorangutan commented Sep 6, 2025

Uh oh!

DaanHoogland commented Sep 8, 2025

Uh oh!

blueorangutan commented Sep 8, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala commented Sep 11, 2025

Uh oh!

blueorangutan commented Sep 11, 2025

Uh oh!

blueorangutan commented Sep 11, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

shwstppr commented Oct 7, 2025

Uh oh!

blueorangutan commented Oct 7, 2025

Uh oh!

blueorangutan commented Oct 7, 2025

Uh oh!

harikrishna-patnala Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Nov 13, 2025

Uh oh!

blueorangutan commented Nov 13, 2025

Uh oh!

blueorangutan commented Nov 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Nov 13, 2025

Uh oh!

blueorangutan commented Nov 13, 2025

Uh oh!

shwstppr commented Sep 6, 2025 •

edited

Loading

codecov bot commented Sep 6, 2025 •

edited

Loading

harikrishna-patnala Oct 8, 2025 •

edited

Loading