Netris: Fix inactive VPCs deletion

[Pearl1594]

Description

This PR addresses an issue with cleanup of inactive VPCs. For whatever reason, if a VPC isn't found on Netris end either due to some out of band operation or due to some other activity, deletion of the VPC fails reporting that it can't find the resource on Netris. This fix makes the check lenient by not failing the cleanup operation if the resource(VPC) isn't found on Netris end - it just logs it and proceeds to clean it up on CloudStack end.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.39%. Comparing base (b46e29d) to head (94fe538).
⚠️ Report is 32 commits behind head on main.

Files with missing lines	Patch %	Lines
...apache/cloudstack/service/NetrisApiClientImpl.java	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11618   +/-   ##
=========================================
  Coverage     17.39%   17.39%           
- Complexity    15279    15282    +3     
=========================================
  Files          5888     5888           
  Lines        526092   526092           
  Branches      64223    64223           
=========================================
  Hits          91527    91527           
  Misses       424233   424233           
  Partials      10332    10332           

Flag	Coverage Δ
uitests	3.62% <ø> (ø)
unittests	18.44% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nvazquez]

LGTM - manually tested

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[weizhouapache]

code lgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 14964

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14356)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51908 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11618-t14356-kvm-ol8.zip
Smoke tests completed. 147 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File