-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix volume copy from primary to primary in simulator #11836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix volume copy from primary to primary in simulator #11836
Conversation
bdfb368 to
7c07466
Compare
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, strange that this was never a problem before
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
vishesh92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. can be merged once github actions pass.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11836 +/- ##
============================================
- Coverage 17.55% 17.55% -0.01%
- Complexity 15524 15526 +2
============================================
Files 5907 5908 +1
Lines 528656 528676 +20
Branches 64555 64559 +4
============================================
- Hits 92807 92802 -5
- Misses 425415 425442 +27
+ Partials 10434 10432 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR fixes the simulator CI test failure
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?