Fix agent wait before reconnect #12153
Conversation
* agent: reconnect after waiting 5 seconds * Update agent/src/main/java/com/cloud/agent/Agent.java * Update agent/src/main/java/com/cloud/agent/Agent.java Co-authored-by: Suresh Kumar Anaparti <[email protected]>
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12153 +/- ##
============================================
- Coverage 16.18% 16.17% -0.01%
+ Complexity 13304 13298 -6
============================================
Files 5657 5657
Lines 498464 498475 +11
Branches 60491 60493 +2
============================================
- Hits 80695 80649 -46
- Misses 408787 408852 +65
+ Partials 8982 8974 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15842 |
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-14873)
|
rajujith
left a comment
rajujith
left a comment
There was a problem hiding this comment.
LGTM
Tested , this resolved the issue. However I would suggest adding autoshutdown after a timeout , unconfigure the agent probably by moving the agent.properties to a backup file and stopping the agent on removal from management server as a separate improvement in future versions.
| } else if (task.getType() == Task.Type.DISCONNECT) { | ||
| logger.debug("Executing disconnect task - {}", () -> getLinkLog(task.getLink())); | ||
| try { | ||
| // an issue has been found if reconnect immediately after disconnecting. please refer to https://github.com/apache/cloudstack/issues/8517 |
There was a problem hiding this comment.
| // an issue has been found if reconnect immediately after disconnecting. please refer to https://github.com/apache/cloudstack/issues/8517 | |
| // an issue has been found if reconnect immediately after disconnecting. |
I think we can refer a github issue in a PR but not in code. We may not be on github forever.
5 participants
Description
There is a regression in 4.20.1 & 4.20.2 which is resulting in the issue #8517.
This PR fixes the agent wait before reconnect, applies the fix in #9258 with minor log updates.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Patched the agent changes to 4.20.2 env with 3 kvm hosts, and restarted agents in all the kvm hosts. Verfied the CPU util in MS.
How did you try to break this feature and the system with this change?