Skip to content

Conversation

@Pearl1594
Copy link
Contributor

Description

This PR allows dedicating backup offerings to domains to be consistent in behaviour with other offerings

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 35.66176% with 175 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.58%. Comparing base (2600965) to head (30ce121).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java 57.64% 27 Missing and 9 partials ⚠️
...stack/backup/dao/BackupOfferingDetailsDaoImpl.java 0.00% 33 Missing ⚠️
...che/cloudstack/backup/BackupOfferingDetailsVO.java 25.00% 21 Missing ⚠️
...ver/src/main/java/com/cloud/acl/DomainChecker.java 0.00% 21 Missing ⚠️
...e/cloudstack/backup/dao/BackupOfferingDaoImpl.java 0.00% 13 Missing ⚠️
.../api/command/offering/DomainAndZoneIdResolver.java 78.72% 0 Missing and 10 partials ⚠️
...c/main/java/com/cloud/user/AccountManagerImpl.java 0.00% 10 Missing ⚠️
.../command/admin/backup/ImportBackupOfferingCmd.java 0.00% 7 Missing ⚠️
...loudstack/api/response/BackupOfferingResponse.java 0.00% 6 Missing ⚠️
.../command/admin/backup/UpdateBackupOfferingCmd.java 42.85% 3 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12194      +/-   ##
============================================
+ Coverage     17.57%   17.58%   +0.01%     
- Complexity    15550    15575      +25     
============================================
  Files          5913     5916       +3     
  Lines        529427   529577     +150     
  Branches      64677    64697      +20     
============================================
+ Hits          93024    93119      +95     
- Misses       425940   425979      +39     
- Partials      10463    10479      +16     
Flag Coverage Δ
uitests 3.58% <ø> (-0.01%) ⬇️
unittests 18.65% <35.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pearl1594 Pearl1594 closed this Dec 5, 2025
@Pearl1594 Pearl1594 reopened this Dec 5, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
30.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant