UI: Create Account form to set proper domain and role based on route #12200
+80
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12200 +/- ##
============================================
- Coverage 17.57% 17.57% -0.01%
- Complexity 15550 15551 +1
============================================
Files 5913 5913
Lines 529428 529450 +22
Branches 64677 64688 +11
============================================
+ Hits 93022 93025 +3
- Misses 425944 425962 +18
- Partials 10462 10463 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an enhancement, where in when we log in as root admin, create a domain and then go to accounts from that domain - while creating the account for the domain, it should correctly select the right domain and role in the create account form.
It also takes care of setting the right role type when changing the domain
As Root Admin:
If domain selected isn't the root domain, then the Role type selected by default will be Domain Admin
If the domain is then changed to root domain, the role type on the form will automatically change to Root Admin.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?