UI: Keyboard Shortcut(s) #8250

apurv-1 · 2023-11-18T13:16:32Z

Description

Adds the support to navigate through CloudStack Management UI with Keyboard.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale

Major
Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

apurv-1 · 2023-11-18T13:24:44Z

@borisstoyanov can we show the list of keyboard shortkeys in a different way? for eg: github (shift+?)

cc: @rohityadavcloud

borisstoyanov · 2023-11-20T08:39:10Z

nice, great to see you back on this @apurv-1! The list you suggest seems good, let me know if you need any help/testing

codecov · 2023-11-20T09:10:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0bc7fb5) 30.75% compared to head (4082d43) 31.22%.

❗ Current head 4082d43 differs from pull request most recent head b0ecf89. Consider uploading reports for the commit b0ecf89 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8250      +/-   ##
============================================
+ Coverage     30.75%   31.22%   +0.47%     
+ Complexity    33910    31081    -2829     
============================================
  Files          5341     4839     -502     
  Lines        374759   338361   -36398     
  Branches      54510    48669    -5841     
============================================
- Hits         115248   105657    -9591     
+ Misses       244276   218202   -26074     
+ Partials      15235    14502     -733

Flag	Coverage Δ
simulator-marvin-tests	`25.15% <ø> (+0.50%)`	⬆️
uitests	`?`
unit-tests	`14.81% <ø> (-1.63%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vishesh92 · 2023-11-20T10:20:23Z

@blueorangutan ui

blueorangutan · 2023-11-20T10:29:04Z

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2023-11-20T10:45:01Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8250 (QA-JID-228)

rohityadavcloud · 2023-11-27T06:36:01Z

Excellent, thanks for raising this @apurv-1

DaanHoogland · 2023-11-27T08:06:42Z

@apurv-1 I know I have asked this and you replied but I can not find the dialog above so;

Will you add the other shortcuts from the old PR as well?

apurv-1 · 2023-11-27T08:39:39Z

@apurv-1 I know I have asked this and you replied but I can not find the dialog above so;

Will you add the other shortcuts from the old PR as well?

Yeah, I am planning to add older shortcuts and but to display shortcuts, I am inclining the way github shows it i.e by opening a dialog. (We can discuss more on this, its just a suggestion right now)

DaanHoogland · 2023-11-27T08:52:16Z

@apurv-1 I know I have asked this and you replied but I can not find the dialog above so;
Will you add the other shortcuts from the old PR as well?

Yeah, I am planning to add older shortcuts and but to display shortcuts, I am inclining the way github shows it i.e by opening a dialog. (We can discuss more on this, its just a suggestion right now)

ok, so do you want this merged as is or add to it first?

DaanHoogland · 2023-11-27T08:53:37Z

@apurv-1 please see the failures in the UI build: https://github.com/apache/cloudstack/actions/runs/6914183873/job/18841522093?pr=8250

apurv-1 · 2023-11-27T11:18:42Z

@apurv-1 I know I have asked this and you replied but I can not find the dialog above so;
Will you add the other shortcuts from the old PR as well?

Yeah, I am planning to add older shortcuts and but to display shortcuts, I am inclining the way github shows it i.e by opening a dialog. (We can discuss more on this, its just a suggestion right now)

ok, so do you want this merged as is or add to it first?

I will add the more shortcuts then add the dialog then it will be ready for merge. Sorry, for confusion will change this to draft PR 😅

github-actions · 2023-12-01T13:32:42Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

rohityadavcloud · 2023-12-12T10:04:27Z

@apurv-1 thanks for the PR (again), could you resolve the conflict? Thanks.

apurv-1 · 2023-12-12T15:44:45Z

@apurv-1 thanks for the PR (again), could you resolve the conflict? Thanks.

Yeah, Sure

github-actions · 2024-04-18T07:38:34Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

codecov-commenter · 2024-04-18T07:40:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.38%. Comparing base (5ea1ada) to head (9b75316).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8250      +/-   ##
============================================
+ Coverage     17.35%   18.38%   +1.03%     
+ Complexity    15186    15182       -4     
============================================
  Files          5883     5442     -441     
  Lines        524318   487502   -36816     
  Branches      63964    57228    -6736     
============================================
- Hits          90980    89628    -1352     
+ Misses       423061   387758   -35303     
+ Partials      10277    10116     -161

Flag	Coverage Δ
uitests	`?`
unittests	`18.38% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland · 2024-04-18T07:47:26Z

@blueorangutan ui

blueorangutan · 2024-04-18T07:48:03Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-04-18T08:03:44Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8250 (QA-JID-315)

DaanHoogland

clgtm and tested in qa

DaanHoogland · 2024-04-18T09:02:52Z

@harikrishna-patnala @shwstppr @borisstoyanov let's merge this finaly

apurv-1 · 2024-04-19T04:30:26Z

@DaanHoogland we can merge this and then have follow up PRs for improvements. We can start with "what are the 10 most used actions that user performs on the UI"? I can start with adding shortkeys for those actions.

DaanHoogland · 2024-04-19T06:27:16Z

@DaanHoogland we can merge this and then have follow up PRs for improvements. We can start with "what are the 10 most used actions that user performs on the UI"? I can start with adding shortkeys for those actions.

Agree, @apurv-1 . I think this would be a good topic to start a new discussion on ;)

vladimirpetrov · 2024-04-21T19:45:55Z

@blueorangutan package

blueorangutan · 2024-04-21T19:48:04Z

@vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

apurv-1 · 2024-04-21T20:11:29Z

@DaanHoogland we can merge this and then have follow up PRs for improvements. We can start with "what are the 10 most used actions that user performs on the UI"? I can start with adding shortkeys for those actions.

Agree, @apurv-1 . I think this would be a good topic to start a new discussion on ;)

@DaanHoogland started a discussion here :)

blueorangutan · 2024-04-21T20:55:19Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9348

vladimirpetrov · 2024-04-25T14:37:17Z

Hi @apurv-1, I tested the feature but it seems that the 'r' shortcut doesn't work on the following pages:

'Domains' page
'Infrastructure' summary page
'Infrastructure' - CPU sockets page
'Infrastructure' - DB/Usage server page
'Configuration' - Global Settings
'Tools' - Import-Export Instances

DaanHoogland · 2024-04-26T06:56:20Z

@vladimirpetrov , do you think that needs to be implemented before we can merge?

vladimirpetrov · 2024-04-29T10:15:01Z

Well, I think we should be consistent - wherever there is a 'Refresh' button, the shortcut must work, so yes, @DaanHoogland

github-actions · 2025-07-29T08:39:07Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2025-07-29T18:06:18Z

@vladimirpetrov I do not think any more effort is going to be put into this. jfyi

DaanHoogland · 2025-07-31T12:35:47Z

@vladimirpetrov (cc @apurv-1 ) I merged main. lets create a new issue from your comment #8250 and continue with this if it tests ok?

✨ initialized with [email protected]

4082d43

boring-cyborg bot added the component:UI label Nov 18, 2023

apurv-1 mentioned this pull request Nov 18, 2023

UI: Keyboard label shortcut #5122

Closed

5 tasks

rohityadavcloud requested review from DaanHoogland, borisstoyanov, harikrishna-patnala and shwstppr November 27, 2023 06:35

apurv-1 marked this pull request as draft November 27, 2023 11:18

github-actions bot added the status:has-conflicts label Dec 1, 2023

Merge branch 'main' into keyboard-shortcuts

b0ecf89

github-actions bot removed the status:has-conflicts label Dec 15, 2023

github-actions bot added the status:has-conflicts label Apr 18, 2024

Merge branch 'main' into keyboard-shortcuts

5ec67af

github-actions bot removed the status:has-conflicts label Apr 18, 2024

DaanHoogland approved these changes Apr 18, 2024

View reviewed changes

DaanHoogland marked this pull request as ready for review April 18, 2024 09:02

Merge branch 'main' into keyboard-shortcuts

a50f313

DaanHoogland closed this Apr 19, 2024

DaanHoogland reopened this Apr 19, 2024

DaanHoogland assigned vladimirpetrov Apr 25, 2024

DaanHoogland changed the title ~~UI: Keyboard Shortcuts~~ UI: Keyboard Shortcut(s) Apr 25, 2024

github-actions bot added the status:has-conflicts label Jul 29, 2025

Merge branch 'main' into keyboard-shortcuts

9b75316

github-actions bot removed the status:has-conflicts label Jul 31, 2025

UI: Keyboard Shortcut(s) #8250

Are you sure you want to change the base?

UI: Keyboard Shortcut(s) #8250

Uh oh!

Conversation

apurv-1 commented Nov 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

apurv-1 commented Nov 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

borisstoyanov commented Nov 20, 2023

Uh oh!

codecov bot commented Nov 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vishesh92 commented Nov 20, 2023

Uh oh!

blueorangutan commented Nov 20, 2023

Uh oh!

blueorangutan commented Nov 20, 2023

Uh oh!

rohityadavcloud commented Nov 27, 2023

Uh oh!

DaanHoogland commented Nov 27, 2023

Uh oh!

apurv-1 commented Nov 27, 2023

Uh oh!

DaanHoogland commented Nov 27, 2023

Uh oh!

DaanHoogland commented Nov 27, 2023

Uh oh!

apurv-1 commented Nov 27, 2023

Uh oh!

github-actions bot commented Dec 1, 2023

Uh oh!

rohityadavcloud commented Dec 12, 2023

Uh oh!

apurv-1 commented Dec 12, 2023

Uh oh!

github-actions bot commented Apr 18, 2024

Uh oh!

codecov-commenter commented Apr 18, 2024 • edited by codecov bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland commented Apr 18, 2024

Uh oh!

blueorangutan commented Apr 18, 2024

Uh oh!

blueorangutan commented Apr 18, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Apr 18, 2024

Uh oh!

apurv-1 commented Apr 19, 2024

Uh oh!

DaanHoogland commented Apr 19, 2024

Uh oh!

vladimirpetrov commented Apr 21, 2024

Uh oh!

blueorangutan commented Apr 21, 2024

Uh oh!

apurv-1 commented Apr 21, 2024

Uh oh!

blueorangutan commented Apr 21, 2024

Uh oh!

vladimirpetrov commented Apr 25, 2024

Uh oh!

DaanHoogland commented Apr 26, 2024

Uh oh!

apurv-1 commented Nov 18, 2023 •

edited

Loading

apurv-1 commented Nov 18, 2023 •

edited

Loading

codecov bot commented Nov 20, 2023 •

edited

Loading

codecov-commenter commented Apr 18, 2024 •

edited by codecov bot

Loading