Skip to content

Conversation

@weizhouapache
Copy link
Member

Description

This PR fixes #9797

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@andrijapanicsb
Copy link
Contributor

@weizhouapache this was spoted only for Ubuntu 22.04+, not sure if EL8 are affected

@weizhouapache
Copy link
Member Author

@weizhouapache this was spoted only for Ubuntu 22.04+, not sure if EL8 are affected

@andrijapanicsb
the package name is the same on ubuntu 22/24 and el8/9

it is a known issue (for me yes)

@codecov
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.78%. Comparing base (46201ee) to head (7bc27d2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##               main    #9799     +/-   ##
===========================================
  Coverage     15.78%   15.78%             
  Complexity    12565    12565             
===========================================
  Files          5627     5627             
  Lines        492260   492260             
  Branches      63882    61404   -2478     
===========================================
  Hits          77710    77710             
  Misses       406076   406076             
  Partials       8474     8474             
Flag Coverage Δ
uitests 4.04% <ø> (ø)
unittests 16.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohityadavcloud rohityadavcloud added this to the 4.19.2.0 milestone Oct 16, 2024
@rohityadavcloud
Copy link
Member

@weizhouapache is this considered critical for 4.20 release? cc @JoaoJandre

@blueorangutan package

@blueorangutan
Copy link

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11357

@weizhouapache
Copy link
Member Author

@blueorangutan test ol9 kvm-ol9

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol9 mgmt + kvm-ol9) has been kicked to run smoke tests

@weizhouapache
Copy link
Member Author

@blueorangutan test ol8 kvm-ol8

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm. packaging is successful.

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-11668)

@weizhouapache
Copy link
Member Author

kicked off tests on

  • ol8
  • ol9
  • ubuntu24
  • debian12

let's wait

@blueorangutan
Copy link

[SF] Trillian test result (tid-11669)
Environment: kvm-debian12 (x2), Advanced Networking with Mgmt server d12
Total time taken: 51942 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9799-t11669-kvm-debian12.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

[SF] Trillian test result (tid-11670)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54498 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9799-t11670-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

[SF] Trillian test result (tid-11673)
Environment: kvm-ubuntu24 (x2), Advanced Networking with Mgmt server u24
Total time taken: 53141 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9799-t11673-kvm-ubuntu24.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_hostha_enable_ha_when_host_disabled Error 4.00 test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance Error 302.04 test_hostha_kvm.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-11667)
Environment: kvm-ol9 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 64695 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9799-t11667-kvm-ol9.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 272.88 test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Error 272.90 test_vpc_redundant.py

@weizhouapache weizhouapache marked this pull request as ready for review October 17, 2024 06:30
@weizhouapache
Copy link
Member Author

this is ready for review

the smoke test results look fine

@rohityadavcloud rohityadavcloud merged commit 627784e into apache:main Oct 17, 2024
26 checks passed
@rohityadavcloud
Copy link
Member

LGTM, tests & review LGTM. Only affects deb packaging that too installation of a required dependency on Ubuntu.

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ubuntu missing dependency libvirt-daemon-driver-storage-rbd

6 participants