Skip to content

Commit 15c7b2d

Browse files
committed
Remove redundant type casts
1 parent 8336ca9 commit 15c7b2d

File tree

10 files changed

+13
-14
lines changed

10 files changed

+13
-14
lines changed

src/main/java/org/apache/commons/beanutils/converters/BooleanArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ public Object convert(final Class type, final Object value) {
207207
final List<String> list = parseElements(value.toString());
208208
final boolean[] results = new boolean[list.size()];
209209
for (int i = 0; i < results.length; i++) {
210-
final String stringValue = (String) list.get(i);
210+
final String stringValue = list.get(i);
211211
final Object result = booleanConverter.convert(Boolean.class, stringValue);
212212
results[i] = ((Boolean) result).booleanValue();
213213
}

src/main/java/org/apache/commons/beanutils/converters/ByteArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public Object convert(final Class type, final Object value) {
112112
final List<String> list = parseElements(value.toString());
113113
final byte[] results = new byte[list.size()];
114114
for (int i = 0; i < results.length; i++) {
115-
results[i] = Byte.parseByte((String) list.get(i));
115+
results[i] = Byte.parseByte(list.get(i));
116116
}
117117
return results;
118118
} catch (final Exception e) {

src/main/java/org/apache/commons/beanutils/converters/CharacterArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public Object convert(final Class type, final Object value) {
112112
final List<String> list = parseElements(value.toString());
113113
final char[] results = new char[list.size()];
114114
for (int i = 0; i < results.length; i++) {
115-
results[i] = ((String) list.get(i)).charAt(0);
115+
results[i] = list.get(i).charAt(0);
116116
}
117117
return results;
118118
} catch (final Exception e) {

src/main/java/org/apache/commons/beanutils/converters/DoubleArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public Object convert(final Class type, final Object value) {
112112
final List<String> list = parseElements(value.toString());
113113
final double[] results = new double[list.size()];
114114
for (int i = 0; i < results.length; i++) {
115-
results[i] = Double.parseDouble((String) list.get(i));
115+
results[i] = Double.parseDouble(list.get(i));
116116
}
117117
return results;
118118
} catch (final Exception e) {

src/main/java/org/apache/commons/beanutils/converters/FloatArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public Object convert(final Class type, final Object value) {
112112
final List<String> list = parseElements(value.toString());
113113
final float[] results = new float[list.size()];
114114
for (int i = 0; i < results.length; i++) {
115-
results[i] = Float.parseFloat((String) list.get(i));
115+
results[i] = Float.parseFloat(list.get(i));
116116
}
117117
return results;
118118
} catch (final Exception e) {

src/main/java/org/apache/commons/beanutils/converters/IntegerArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public Object convert(final Class type, final Object value) {
112112
final List<String> list = parseElements(value.toString());
113113
final int[] results = new int[list.size()];
114114
for (int i = 0; i < results.length; i++) {
115-
results[i] = Integer.parseInt((String) list.get(i));
115+
results[i] = Integer.parseInt(list.get(i));
116116
}
117117
return results;
118118
} catch (final Exception e) {

src/main/java/org/apache/commons/beanutils/converters/LongArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public Object convert(final Class type, final Object value) {
112112
final List<String> list = parseElements(value.toString());
113113
final long[] results = new long[list.size()];
114114
for (int i = 0; i < results.length; i++) {
115-
results[i] = Long.parseLong((String) list.get(i));
115+
results[i] = Long.parseLong(list.get(i));
116116
}
117117
return results;
118118
} catch (final Exception e) {

src/main/java/org/apache/commons/beanutils/converters/ShortArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ public Object convert(final Class type, final Object value) {
112112
final List<String> list = parseElements(value.toString());
113113
final short[] results = new short[list.size()];
114114
for (int i = 0; i < results.length; i++) {
115-
results[i] = Short.parseShort((String) list.get(i));
115+
results[i] = Short.parseShort(list.get(i));
116116
}
117117
return results;
118118
} catch (final Exception e) {

src/main/java/org/apache/commons/beanutils/converters/StringArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public Object convert(final Class type, final Object value) {
137137
final List<String> list = parseElements(value.toString());
138138
final String[] results = new String[list.size()];
139139
for (int i = 0; i < results.length; i++) {
140-
results[i] = (String) list.get(i);
140+
results[i] = list.get(i);
141141
}
142142
return results;
143143
} catch (final Exception e) {

src/test/java/org/apache/commons/beanutils/locale/LocaleConvertUtilsTestCase.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import java.sql.Date;
2121
import java.sql.Time;
2222
import java.sql.Timestamp;
23-
import java.text.DecimalFormat;
2423
import java.text.NumberFormat;
2524
import java.util.Locale;
2625

@@ -281,7 +280,7 @@ public void setUp() {
281280

282281
LocaleConvertUtils.deregister();
283282

284-
final NumberFormat nf = DecimalFormat.getNumberInstance();
283+
final NumberFormat nf = NumberFormat.getNumberInstance();
285284
final String result = nf.format(1.1);
286285

287286
// could be commas instead of stops in Europe.
@@ -337,9 +336,9 @@ public void testConvertStringLocaleNull() {
337336
* converters have been generified.)
338337
*/
339338
public void testDefaultToStringConversionUnsupportedType() {
340-
final Integer value = 20131101;
341-
assertEquals("Wrong result", value.toString(),
342-
LocaleConvertUtils.convert(value.toString(), getClass()));
339+
final int value = 20131101;
340+
assertEquals("Wrong result", Integer.toString(value),
341+
LocaleConvertUtils.convert(Integer.toString(value), getClass()));
343342
}
344343

345344
/**

0 commit comments

Comments
 (0)