Fix typo in exception message throws from

garydgregory · garydgregory · commit 227583d3e8c4 · 2025-07-20T16:28:14.000-04:00
org.apache.commons.beanutils.PropertyUtilsBean.setMappedProperty(Object,
String, String, Object)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -30,6 +30,7 @@
   <body>
     <release version="1.11.1" date="YYYY-MM-DD" description="This is a maintenance release and requires Java 8.">
       <!-- FIX -->
+      <action dev="ggregory" type="update" due-to="Gary Gregory">Fix typo in exception message throws from org.apache.commons.beanutils.PropertyUtilsBean.setMappedProperty(Object, String, String, Object).</action>
       <!-- ADD -->
       <!-- UPDATE -->
       <action dev="ggregory" type="update" due-to="Gary Gregory">Bump org.apache.commons:commons-parent from 84 to 85.</action>
diff --git a/src/main/java/org/apache/commons/beanutils/PropertyUtilsBean.java b/src/main/java/org/apache/commons/beanutils/PropertyUtilsBean.java
@@ -1280,7 +1280,7 @@ public Method getWriteMethod(final PropertyDescriptor descriptor) {
     /** This just catches and wraps IllegalArgumentException. */
     private Object invokeMethod(final Method method, final Object bean, final Object[] values) throws IllegalAccessException, InvocationTargetException {
         if (bean == null) {
-            throw new IllegalArgumentException("No bean specified " + "- this should have been checked before reaching this method");
+            throw new IllegalArgumentException("No bean specified - this should have been checked before reaching this method");
         }
         try {
             return method.invoke(bean, values);
@@ -1707,7 +1707,7 @@ public void setMappedProperty(final Object bean, final String name, final String
             Method mappedWriteMethod = ((MappedPropertyDescriptor) descriptor).getMappedWriteMethod();
             mappedWriteMethod = MethodUtils.getAccessibleMethod(bean.getClass(), mappedWriteMethod);
             if (mappedWriteMethod == null) {
-                throw new NoSuchMethodException("Property '" + name + "' has no mapped setter method" + "on bean class '" + bean.getClass() + "'");
+                throw new NoSuchMethodException("Property '" + name + "' has no mapped setter method on bean class '" + bean.getClass() + "'");
             }
             final Object[] params = new Object[2];
             params[0] = key;
@@ -1860,7 +1860,7 @@ protected void setPropertyOfMapBean(final Map<String, Object> bean, String prope
         }
 
         if (resolver.isIndexed(propertyName) || resolver.isMapped(propertyName)) {
-            throw new IllegalArgumentException("Indexed or mapped properties are not supported on" + " objects of type Map: " + propertyName);
+            throw new IllegalArgumentException("Indexed or mapped properties are not supported on objects of type Map: " + propertyName);
         }
 
         bean.put(propertyName, value);
diff --git a/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java b/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
@@ -145,8 +145,8 @@ private String getMemoryStats() {
         final long free = runtime.freeMemory() / 1024;
         final long total = runtime.totalMemory() / 1024;
         final long used = total - free;
-        return "MEMORY - Total: " + fmt.format(total) + "k " + "Used: "
-                + fmt.format(used) + "k " + "Free: "
+        return "MEMORY - Total: " + fmt.format(total) + "k Used: "
+                + fmt.format(used) + "k Free: "
                 + fmt.format(free) + "k";
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1280,7 +1280,7 @@ public Method getWriteMethod(final PropertyDescriptor descriptor) {`
`1280`	`1280`	`/** This just catches and wraps IllegalArgumentException. */`
`1281`	`1281`	`private Object invokeMethod(final Method method, final Object bean, final Object[] values) throws IllegalAccessException, InvocationTargetException {`
`1282`	`1282`	`if (bean == null) {`
`1283`		`- throw new IllegalArgumentException("No bean specified " + "- this should have been checked before reaching this method");`
	`1283`	`+ throw new IllegalArgumentException("No bean specified - this should have been checked before reaching this method");`
`1284`	`1284`	`}`
`1285`	`1285`	`try {`
`1286`	`1286`	`return method.invoke(bean, values);`
`@@ -1707,7 +1707,7 @@ public void setMappedProperty(final Object bean, final String name, final String`
`1707`	`1707`	`Method mappedWriteMethod = ((MappedPropertyDescriptor) descriptor).getMappedWriteMethod();`
`1708`	`1708`	`mappedWriteMethod = MethodUtils.getAccessibleMethod(bean.getClass(), mappedWriteMethod);`
`1709`	`1709`	`if (mappedWriteMethod == null) {`
`1710`		`- throw new NoSuchMethodException("Property '" + name + "' has no mapped setter method" + "on bean class '" + bean.getClass() + "'");`
	`1710`	`+ throw new NoSuchMethodException("Property '" + name + "' has no mapped setter method on bean class '" + bean.getClass() + "'");`
`1711`	`1711`	`}`
`1712`	`1712`	`final Object[] params = new Object[2];`
`1713`	`1713`	`params[0] = key;`
`@@ -1860,7 +1860,7 @@ protected void setPropertyOfMapBean(final Map<String, Object> bean, String prope`
`1860`	`1860`	`}`
`1861`	`1861`
`1862`	`1862`	`if (resolver.isIndexed(propertyName) \|\| resolver.isMapped(propertyName)) {`
`1863`		`- throw new IllegalArgumentException("Indexed or mapped properties are not supported on" + " objects of type Map: " + propertyName);`
	`1863`	`+ throw new IllegalArgumentException("Indexed or mapped properties are not supported on objects of type Map: " + propertyName);`
`1864`	`1864`	`}`
`1865`	`1865`
`1866`	`1866`	`bean.put(propertyName, value);`