Static fields should be final or protected by synch.

Author: sebbASF

src/changes/changes.xml

@@ -33,6 +33,7 @@
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix typo in exception message throws from org.apache.commons.beanutils2.PropertyUtilsBean.setMappedProperty(Object, String, String, Object).</action>
       <action type="fix" dev="ggregory" due-to="Basil Crow, Piotr P. Karwasz, Gary Gregory">Simplify FluentPropertyBeanIntrospector#propertyName (#363).</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix malformed Javadoc comments.</action>
+      <action type="fix" dev="sebb">Static fields should be final or protected by synch.</action>
       <!-- ADD -->
       <action type="add" dev="ggregory" due-to="Gary Gregory">Use varargs for org.apache.commons.beanutils2.MethodUtils.getAccessibleMethod(Class, String, Class...), and remove last argument variants using Class[] and Class.</action>
       <action type="add" dev="ggregory" due-to="SethFalco, Melloware, Gary Gregory">Add Instant converter and improve enum converter #49.</action>

src/main/java/org/apache/commons/beanutils2/LazyDynaBean.java

@@ -129,7 +129,7 @@ public class LazyDynaBean implements DynaBean {
     /**
      * Commons Logging
      */
-    private static transient Log LOG = LogFactory.getLog(LazyDynaBean.class);
+    private static final transient Log LOG = LogFactory.getLog(LazyDynaBean.class);
 
     /** BigInteger Zero */
     protected static final BigInteger BigInteger_ZERO = new BigInteger("0");
@@ -673,9 +673,6 @@ protected boolean isDynaProperty(final String name) {
      * Returns the {@code Log}.
      */
     private Log logger() {
-        if (LOG == null) {
-            LOG = LogFactory.getLog(LazyDynaBean.class);
-        }
         return LOG;
     }
 

src/main/java/org/apache/commons/beanutils2/MethodUtils.java

@@ -118,7 +118,7 @@ public String toString() {
      * would mean having a map keyed by context classloader which may introduce memory-leak problems.
      * </p>
      */
-    private static boolean CACHE_ENABLED = true;
+    private static boolean CACHE_ENABLED = true; //NOPMD @GuardedBy("this")
 
     /**
      * Stores a cache of MethodKey -> Method.