ResultSetIterator.get(String) now throws IllegalArgumentException

instead of RuntimeException to wrap cases of SQLException

- ResultSetIterator.hasNext() now throws IllegalArgumentException
instead of RuntimeException to wrap cases of SQLException
- ResultSetIterator.set(String, Object) now throws
IllegalArgumentException instead of RuntimeException to wrap cases of
SQLException
- ResultSetIterator.set(String, String, Object) now throws
IllegalArgumentException instead of RuntimeException to wrap cases of
SQLException.</action>

Author: garydgregory

src/changes/changes.xml

@@ -32,6 +32,10 @@
       <!-- FIX -->
       <action type="fix" dev="ggregory" due-to="Gary Gregory">BeanComparator.compare(T, T) now throws IllegalArgumentException instead of RuntimeException to wrap all cases of ReflectiveOperationException.</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">MappedMethodReference.get() now throws IllegalStateException instead of RuntimeException to wrap cases of NoSuchMethodException.</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">ResultSetIterator.get(String) now throws IllegalArgumentException instead of RuntimeException to wrap cases of SQLException.</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">ResultSetIterator.hasNext() now throws IllegalArgumentException instead of RuntimeException to wrap cases of SQLException.</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">ResultSetIterator.set(String, Object) now throws IllegalArgumentException instead of RuntimeException to wrap cases of SQLException.</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">ResultSetIterator.set(String, String, Object) now throws IllegalArgumentException instead of RuntimeException to wrap cases of SQLException.</action>
       <!-- ADD -->
       <!-- UPDATE -->
     </release>

src/main/java/org/apache/commons/beanutils/ResultSetIterator.java

@@ -110,8 +110,7 @@ public Object get(final String name) {
         try {
             return dynaClass.getObjectFromResultSet(name);
         } catch (final SQLException e) {
-            throw new RuntimeException
-                ("get(" + name + "): SQLException: " + e);
+            throw new IllegalArgumentException("get(" + name + "): SQLException: " + e, e);
         }
     }
 
@@ -177,7 +176,7 @@ public boolean hasNext() {
             advance();
             return !eof;
         } catch (final SQLException e) {
-            throw new RuntimeException("hasNext():  SQLException:  " + e);
+            throw new IllegalArgumentException("hasNext():  SQLException:  " + e, e);
         }
     }
 
@@ -196,7 +195,7 @@ public DynaBean next() {
             current = false;
             return this;
         } catch (final SQLException e) {
-            throw new RuntimeException("next():  SQLException:  " + e);
+            throw new IllegalArgumentException("next():  SQLException:  " + e, e);
         }
 
     }
@@ -267,8 +266,7 @@ public void set(final String name, final Object value) {
         try {
             dynaClass.getResultSet().updateObject(name, value);
         } catch (final SQLException e) {
-            throw new RuntimeException
-                ("set(" + name + "): SQLException: " + e);
+            throw new IllegalArgumentException("set(" + name + "): SQLException: " + e, e);
         }
     }
 
@@ -287,8 +285,7 @@ public void set(final String name, final Object value) {
      */
     @Override
     public void set(final String name, final String key, final Object value) {
-        throw new UnsupportedOperationException
-            ("FIXME - mapped properties not currently supported");
+        throw new UnsupportedOperationException("FIXME - mapped properties not currently supported");
     }
 
 }