Remove org.apache.commons.beanutils2.MethodUtils.isAssignmentCompatible(Class

toClass, Class cls) in favor
oforg.apache.commons.lang3.ClassUtils.isAssignable(Class cls, Class
toClass)

Author: garydgregory

src/changes/changes.xml

@@ -49,7 +49,8 @@
       <action dev="ggregory" type="remove" due-to="Gary Gregory">Remove unused org.apache.commons.beanutils2.MethodUtils.invokeStaticMethod(Class, String, Object[], Class[]) in favor of Apache Commons Lang's org.apache.commons.lang3.reflect.MethodUtils.</action>
       <action dev="ggregory" type="remove" due-to="Gary Gregory">Remove unused org.apache.commons.beanutils2.MethodUtils.toNonPrimitiveClass(Class) in favor of org.apache.commons.lang3.ClassUtils.primitiveToWrapper(Class).</action>
       <action dev="ggregory" type="remove" due-to="Gary Gregory">Remove unused org.apache.commons.beanutils2.MethodUtils.getPrimitiveType(Class) in favor of org.apache.commons.lang3.ClassUtils.wrapperToPrimitive(Class).</action>
-      <action dev="ggregory" type="remove" due-to="Gary Gregory">Remove unused org.apache.commons.beanutils2.MethodUtils.getPrimitiveWrapper(Class) in favor of org.apache.commons.lang3.ClassUtils.primitiveToWrapper(Class).</action>
+      <action dev="ggregory" type="remove" due-to="Gary Gregory">Remove org.apache.commons.beanutils2.MethodUtils.getPrimitiveWrapper(Class) in favor of org.apache.commons.lang3.ClassUtils.primitiveToWrapper(Class).</action>
+      <action dev="ggregory" type="remove" due-to="Gary Gregory">Remove org.apache.commons.beanutils2.MethodUtils.isAssignmentCompatible(Class toClass, Class cls) in favor oforg.apache.commons.lang3.ClassUtils.isAssignable(Class cls, Class toClass).</action>
     </release>
     <release version="2.0.0-M2" date="2025-05-25" description="This is a major release and requires Java 8.">
       <!-- FIX -->

src/main/java/org/apache/commons/beanutils2/MethodUtils.java

@@ -443,7 +443,7 @@ public static Method getMatchingAccessibleMethod(final Class<?> clazz, final Str
                             LOG.trace("Param=" + parameterTypes[n].getName());
                             LOG.trace("Method=" + methodsParams[n].getName());
                         }
-                        if (!isAssignmentCompatible(methodsParams[n], parameterTypes[n])) {
+                        if (!ClassUtils.isAssignable(parameterTypes[n], methodsParams[n])) {
                             if (LOG.isTraceEnabled()) {
                                 LOG.trace(methodsParams[n] + " is not assignable from " + parameterTypes[n]);
                             }
@@ -500,7 +500,8 @@ private static float getObjectTransformationCost(Class<?> srcClass, final Class<
                     break;
                 }
             }
-            if (destClass.isInterface() && isAssignmentCompatible(destClass, srcClass)) {
+            final Class<?> cls = srcClass;
+            if (destClass.isInterface() && ClassUtils.isAssignable(cls, destClass)) {
                 // slight penalty for interface match.
                 // we still want an exact match to override an interface match, but
                 // an interface match should override anything where we have to get a
@@ -688,42 +689,6 @@ public static Object invokeMethod(final Object object, final String methodName,
         return method.invoke(object, args);
     }
 
-    /**
-     * <p>
-     * Determine whether a type can be used as a parameter in a method invocation. This method handles primitive conversions correctly.
-     * </p>
-     *
-     * <p>
-     * In order words, it will match a {@code Boolean</code> to a <code>boolean},
-     * a {@code Long</code> to a <code>long},
-     * a {@code Float</code> to a <code>float},
-     * a {@code Integer</code> to a <code>int},
-     * and a {@code Double</code> to a <code>double}.
-     * Now logic widening matches are allowed.
-     * For example, a {@code Long</code> will not match a <code>int}.
-     *
-     * @param parameterType    the type of parameter accepted by the method
-     * @param parameterization the type of parameter being tested
-     * @return true if the assignment is compatible.
-     */
-    public static boolean isAssignmentCompatible(final Class<?> parameterType, final Class<?> parameterization) {
-        // try plain assignment
-        if (parameterType.isAssignableFrom(parameterization)) {
-            return true;
-        }
-
-        if (parameterType.isPrimitive()) {
-            // this method does *not* do widening - you must specify exactly
-            // is this the right behavior?
-            final Class<?> parameterWrapperClazz = ClassUtils.wrapperToPrimitive(parameterType);
-            if (parameterWrapperClazz != null) {
-                return parameterWrapperClazz.equals(parameterization);
-            }
-        }
-
-        return false;
-    }
-
     /**
      * Sets whether methods should be cached for greater performance or not, default is {@code true}.
      *

src/test/java/org/apache/commons/beanutils2/bugs/Jira381Test.java

@@ -67,13 +67,10 @@ public void performOp(final TestObject o) {
      */
     @Test
     void testIssue_BEANUTILS_381_getMatchingAccessibleMethod() {
-
         final Class<?> target = TestServiceBean.class;
         final String methodName = "performOp";
         final Class<?>[] runtimeClasses = { TestObjectSubclass.class };
-
         final Method returned = MethodUtils.getMatchingAccessibleMethod(target, methodName, runtimeClasses);
-
         assertEquals(target, returned.getDeclaringClass());
         assertEquals(methodName, returned.getName());
         assertEquals(TestObject.class, returned.getParameterTypes()[0]);