Don't initialize instance variables to their default values

Author: garydgregory

src/main/java/org/apache/commons/beanutils/WrapDynaClass.java

@@ -269,7 +269,7 @@ private static Map<Object, Object> getDynaClassesMap() {
     /**
      * Name of the JavaBean class represented by this WrapDynaClass.
      */
-    private String beanClassName = null;
+    private String beanClassName;
 
     /**
      * Reference to the JavaBean class represented by this WrapDynaClass.

src/main/java/org/apache/commons/beanutils/converters/AbstractConverter.java

@@ -77,7 +77,7 @@ public abstract class AbstractConverter implements Converter {
     /**
      * The default value specified to our Constructor, if any.
      */
-    private Object defaultValue = null;
+    private Object defaultValue;
 
 
     /**

src/main/java/org/apache/commons/beanutils/locale/BaseLocaleConverter.java

@@ -72,7 +72,7 @@ private static <T> T checkConversionResult(final Class<T> type, final Object res
     private final Log log = LogFactory.getLog(BaseLocaleConverter.class);
 
     /** The default value specified to our Constructor, if any. */
-    private Object defaultValue = null;
+    private Object defaultValue;
 
     /** Should we return the default value on conversion errors? */
     protected boolean useDefault = false;

src/test/java/org/apache/commons/beanutils/BeanUtilsBenchCase.java

@@ -54,20 +54,20 @@ public static Test suite() {
     private long counter = 100000;
 
     // DynaClass for inDyna and outDyna
-    private DynaClass dynaClass = null;
+    private DynaClass dynaClass;
 
     // Input objects that have identical sets of properties and values.
-    private BenchBean inBean = null;
-    private DynaBean inDyna = null;
+    private BenchBean inBean;
+    private DynaBean inDyna;
     private Map<String, Object> inMap = null;  // Map of Objects requiring no conversion
     private Map<String, String> inStrs = null; // Map of Strings requiring conversion
 
     // Output objects that have identical sets of properties.
-    private BenchBean outBean = null;
-    private DynaBean outDyna = null;
+    private BenchBean outBean;
+    private DynaBean outDyna;
 
     // BeanUtilsBean instance to be used
-    private BeanUtilsBean bu = null;
+    private BeanUtilsBean bu;
 
 
 

src/test/java/org/apache/commons/beanutils/IndexedPropertyTestCase.java

@@ -43,7 +43,7 @@ public class IndexedPropertyTestCase {
     /**
      * The test bean for each test.
      */
-    private IndexedTestBean bean = null;
+    private IndexedTestBean bean;
     private BeanUtilsBean beanUtilsBean;
     private PropertyUtilsBean propertyUtilsBean;
     private String[] testArray;

src/test/java/org/apache/commons/beanutils/PropertyUtilsBenchCase.java

@@ -53,19 +53,19 @@ public static Test suite() {
     private long counter = 100000;
 
     // DynaClass for inDyna and outDyna
-    private DynaClass dynaClass = null;
+    private DynaClass dynaClass;
 
     // Input objects that have identical sets of properties and values.
-    private BenchBean inBean = null;
-    private DynaBean inDyna = null;
+    private BenchBean inBean;
+    private DynaBean inDyna;
     private Map<String, Object> inMap = null;
 
     // Output objects that have identical sets of properties.
-    private BenchBean outBean = null;
-    private DynaBean outDyna = null;
+    private BenchBean outBean;
+    private DynaBean outDyna;
 
     // PropertyUtilsBean instance to be used
-    private PropertyUtilsBean pu = null;
+    private PropertyUtilsBean pu;
 
 
 

src/test/java/org/apache/commons/beanutils/TestBean.java

@@ -184,24 +184,24 @@ public static void incrementCounter(final Number amount) {
     /**
      * A nested reference to another test bean (populated as needed).
      */
-    private TestBean nested = null;
+    private TestBean nested;
 
     /**
         * Another nested reference to another test bean,
         */
-       private TestBean anotherNested = null;
+       private TestBean anotherNested;
 
     /**
         * Another nested reference to another test bean,
         */
-       private DynaBean nestedDynaBean = null;
+       private DynaBean nestedDynaBean;
 
-    private MappedTestBean mappedNested = null;
+    private MappedTestBean mappedNested;
 
     /**
      * A String property with an initial value of null.
      */
-    private String nullProperty = null;
+    private String nullProperty;
 
     /**
      * A read-only String property.

src/test/java/org/apache/commons/beanutils/bugs/Jira411TestCase.java

@@ -30,7 +30,7 @@ public class Jira411TestCase extends TestCase {
 
     public class DummyBean {
 
-        private String imgLink = null;
+        private String imgLink;
 
         public String getImgLink() {
             return imgLink;

src/test/java/org/apache/commons/beanutils/converters/BigDecimalConverterTestCase.java

@@ -51,7 +51,7 @@ public static TestSuite suite() {
 
     // ------------------------------------------------------------------------
 
-    private Converter converter = null;
+    private Converter converter;
 
     public BigDecimalConverterTestCase(final String name) {
         super(name);

src/test/java/org/apache/commons/beanutils/converters/BigIntegerConverterTestCase.java

@@ -36,7 +36,7 @@ public static TestSuite suite() {
 
     // ------------------------------------------------------------------------
 
-    private Converter converter = null;
+    private Converter converter;
 
     // ------------------------------------------------------------------------