Remove unused

org.apache.commons.beanutils2.MethodUtils.invokeMethod(Object, String,
Object) in favor of Apache Commons Lang's MethodUtils

Author: garydgregory

src/changes/changes.xml

@@ -43,6 +43,7 @@
       <action dev="ggregory" type="remove" due-to="Gary Gregory">Remove unused org.apache.commons.beanutils2.MethodUtils.invokeExactStaticMethod(Class, String, Object) in favor of Apache Commons Lang's MethodUtils.</action>
       <action dev="ggregory" type="remove" due-to="Gary Gregory">Remove unused org.apache.commons.beanutils2.MethodUtils.invokeExactStaticMethod(Class, String, Object) in favor of Apache Commons Lang's MethodUtils.</action>
       <action dev="ggregory" type="remove" due-to="Gary Gregory">Remove unused org.apache.commons.beanutils2.MethodUtils.invokeExactStaticMethod(Class, String, Object[]) in favor of Apache Commons Lang's MethodUtils.</action>
+      <action dev="ggregory" type="remove" due-to="Gary Gregory">Remove unused org.apache.commons.beanutils2.MethodUtils.invokeMethod(Object, String, Object) in favor of Apache Commons Lang's MethodUtils.</action>
     </release>
     <release version="2.0.0-M2" date="2025-05-25" description="This is a major release and requires Java 8.">
       <!-- FIX -->

src/main/java/org/apache/commons/beanutils2/MethodUtils.java

@@ -632,7 +632,7 @@ private static float getTotalTransformationCost(final Class<?>[] srcArgs, final
      * @throws InvocationTargetException wraps an exception thrown by the method invoked
      * @throws IllegalAccessException    if the requested method is not accessible via reflection
      */
-    public static Object invokeExactMethod(final Object object, final String methodName, Object[] args)
+    public static Object invokeExactMethod(final Object object, final String methodName, Object... args)
             throws NoSuchMethodException, IllegalAccessException, InvocationTargetException {
         if (args == null) {
             args = BeanUtils.EMPTY_OBJECT_ARRAY;
@@ -718,39 +718,6 @@ public static Object invokeExactStaticMethod(final Class<?> objectClass, final S
         return method.invoke(null, args);
     }
 
-    /**
-     * <p>
-     * Invoke a named method whose parameter type matches the object type.
-     * </p>
-     *
-     * <p>
-     * The behavior of this method is less deterministic than {@code invokeExactMethod()}. It loops through all methods with names that match and then executes
-     * the first it finds with compatible parameters.
-     * </p>
-     *
-     * <p>
-     * This method supports calls to methods taking primitive parameters via passing in wrapping classes. So, for example, a {@code Boolean} class would match a
-     * {@code boolean} primitive.
-     * </p>
-     *
-     * <p>
-     * This is a convenient wrapper for {@link #invokeMethod(Object object,String methodName,Object [] args)}.
-     * </p>
-     *
-     * @param object     invoke method on this object
-     * @param methodName get method with this name
-     * @param arg        use this argument. May be null (this will result in calling the parameterless method with name {@code methodName}).
-     * @return The value returned by the invoked method
-     * @throws NoSuchMethodException     if there is no such accessible method
-     * @throws InvocationTargetException wraps an exception thrown by the method invoked
-     * @throws IllegalAccessException    if the requested method is not accessible via reflection
-     */
-    public static Object invokeMethod(final Object object, final String methodName, final Object arg)
-            throws NoSuchMethodException, IllegalAccessException, InvocationTargetException {
-        final Object[] args = toArray(arg);
-        return invokeMethod(object, methodName, args);
-    }
-
     /**
      * <p>
      * Invoke a named method whose parameter type matches the object type.

src/test/java/org/apache/commons/beanutils2/MethodUtilsTest.java

@@ -19,7 +19,6 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertInstanceOf;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.lang.reflect.Method;
@@ -65,7 +64,7 @@ public void tearDown() {
     void testClearCache() throws Exception {
         MethodUtils.clearCache(); // make sure it starts empty
         final PublicSubBean bean = new PublicSubBean();
-        MethodUtils.invokeMethod(bean, "setFoo", "alpha");
+        MethodUtils.invokeExactMethod(bean, "setFoo", "alpha");
         assertEquals(1, MethodUtils.clearCache());
         assertEquals(0, MethodUtils.clearCache());
     }
@@ -113,18 +112,6 @@ void testInvokeExactMethodNullArrayNullArray() throws Exception {
         assertEquals("parent", result);
     }
 
-    /**
-     * <p>
-     * Test {@code invokeMethod}.
-     */
-    @Test
-    void testInvokeMethod() throws Exception {
-        final AbstractParent parent = new AlphaBean("parent");
-        final BetaBean childOne = new BetaBean("ChildOne");
-
-        assertEquals("ChildOne", MethodUtils.invokeMethod(parent, "testAddChild", childOne), "Cannot invoke through abstract class (1)");
-    }
-
     @Test
     void testInvokeMethodArray() throws Exception {
         final AbstractParent parent = new AlphaBean("parent");
@@ -137,13 +124,6 @@ void testInvokeMethodArray() throws Exception {
         assertEquals("ChildTwo", MethodUtils.invokeMethod(parent, "testAddChild2", params), "Cannot invoke through abstract class");
     }
 
-    @Test
-    void testInvokeMethodNull() throws Exception {
-        final Object object = new Object();
-        final Object result = MethodUtils.invokeMethod(object, "toString", (Object) null);
-        assertEquals(object.toString(), result);
-    }
-
     @Test
     void testInvokeMethodNullArray() throws Exception {
         final Object result = MethodUtils.invokeMethod(new AlphaBean("parent"), "getName", null);
@@ -158,79 +138,19 @@ void testInvokeMethodNullArrayNullArray() throws Exception {
         assertEquals("parent", result);
     }
 
-    @Test
-    void testInvokeMethodObject() throws Exception {
-        final AbstractParent parent = new AlphaBean("parent");
-        final Child childTwo = new AlphaBean("ChildTwo");
-
-        assertEquals("ChildTwo", MethodUtils.invokeMethod(parent, "testAddChild", childTwo), "Cannot invoke through interface (1)");
-    }
-
-    @Test
-    void testInvokeMethodPrimitiveBoolean() throws Exception {
-        final PrimitiveBean bean = new PrimitiveBean();
-        MethodUtils.invokeMethod(bean, "setBoolean", Boolean.FALSE);
-        assertEquals(false, bean.getBoolean(), "Call boolean property using invokeMethod");
-    }
-
-    @Test
-    void testInvokeMethodPrimitiveDouble() throws Exception {
-        final PrimitiveBean bean = new PrimitiveBean();
-        MethodUtils.invokeMethod(bean, "setDouble", Double.valueOf(25.5d));
-        assertEquals(25.5d, bean.getDouble(), 0.01d, "Set double property using invokeMethod");
-    }
-
-    @Test
-    void testInvokeMethodPrimitiveFloat() throws Exception {
-        final PrimitiveBean bean = new PrimitiveBean();
-        MethodUtils.invokeMethod(bean, "setFloat", Float.valueOf(20.0f));
-        assertEquals(20.0f, bean.getFloat(), 0.01f, "Call float property using invokeMethod");
-    }
-
-    @Test
-    void testInvokeMethodPrimitiveInt() throws Exception {
-        final PrimitiveBean bean = new PrimitiveBean();
-        MethodUtils.invokeMethod(bean, "setInt", Integer.valueOf(12));
-        assertEquals(12, bean.getInt(), "Set int property using invokeMethod");
-    }
-
-    @Test
-    void testInvokeMethodPrimitiveLong() throws Exception {
-        final PrimitiveBean bean = new PrimitiveBean();
-        MethodUtils.invokeMethod(bean, "setLong", Long.valueOf(10));
-        assertEquals(10, bean.getLong(), "Call long property using invokeMethod");
-    }
-
-    @Test
-    void testInvokeMethodUnknown() throws Exception {
-        // test that exception is correctly thrown when a method cannot be found with matching params
-        final AbstractParent parent = new AlphaBean("parent");
-        final BetaBean childOne = new BetaBean("ChildOne");
-        assertThrows(NoSuchMethodException.class, () -> MethodUtils.invokeMethod(parent, "bogus", childOne));
-    }
-
     @Test
     void testNoCaching() throws Exception {
         // no caching
         MethodUtils.setCacheMethods(false);
 
         final PublicSubBean bean = new PublicSubBean();
-        MethodUtils.invokeMethod(bean, "setFoo", "alpha");
+        MethodUtils.invokeExactMethod(bean, "setFoo", "alpha");
         assertEquals(0, MethodUtils.clearCache());
 
         // reset default
         MethodUtils.setCacheMethods(true);
     }
 
-    @Test
-    void testParentMethod() throws Exception {
-        final String a = "A";
-        final String actual1 = (String) MethodUtils.invokeMethod(a, "toLowerCase", null);
-        assertEquals("a", actual1);
-        final char actual2 = (char) MethodUtils.invokeMethod(a, "charAt", 0);
-        assertEquals('A', actual2);
-    }
-
     @Test
     void testPublicSub() throws Exception {
         // make sure that bean does what it should
@@ -244,9 +164,9 @@ void testPublicSub() throws Exception {
 
         // see if we can access public methods in a default access superclass
         // from a public access subclass instance
-        MethodUtils.invokeMethod(bean, "setFoo", "alpha");
+        MethodUtils.invokeExactMethod(bean, "setFoo", "alpha");
         assertEquals(bean.getFoo(), "alpha", "Set value (foo:2)");
-        MethodUtils.invokeMethod(bean, "setBar", "beta");
+        MethodUtils.invokeExactMethod(bean, "setBar", "beta");
         assertEquals(bean.getBar(), "beta", "Set value (bar:2)");
 
         Method method = MethodUtils.getAccessibleMethod(PublicSubBean.class, "setFoo", String.class);
@@ -270,7 +190,7 @@ void testSetCacheMethods() throws Exception {
         MethodUtils.clearCache(); // make sure it starts empty
 
         final PublicSubBean bean = new PublicSubBean();
-        MethodUtils.invokeMethod(bean, "setFoo", "alpha");
+        MethodUtils.invokeExactMethod(bean, "setFoo", "alpha");
         assertEquals(1, MethodUtils.clearCache());
         assertEquals(0, MethodUtils.clearCache());
     }