Skip to content

Commit a5ef8b1

Browse files
committed
AbstractArrayConverter.parseElements(String) now returns a
List<String> instead of a raw List
1 parent f498c9b commit a5ef8b1

11 files changed

+11
-10
lines changed

src/changes/changes.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
<action type="fix" dev="ggregory" due-to="Gary Gregory">Replace Maven CLIRR plugin with JApiCmp.</action>
3636
<action type="fix" dev="ggregory" due-to="Gary Gregory">Port to Java 1.4 Throwable APIs (!).</action>
3737
<action type="fix" dev="ggregory" due-to="Gary Gregory">Fix Javadoc generation on Java 8, 17, and 21.</action>
38+
<action type="fix" dev="ggregory" due-to="Gary Gregory">AbstractArrayConverter.parseElements(String) now returns a List&lt;String&gt; instead of a raw List.</action>
3839
<!-- UPDATE -->
3940
<action dev="ggregory" type="update" due-to="Gary Gregory">Bump org.apache.commons:commons-parent from 47 to 78.</action>
4041
<action dev="ggregory" type="update" due-to="Gary Gregory">Bump Java requirement from Java 6 to 8.</action>

src/main/java/org/apache/commons/beanutils/converters/AbstractArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ public AbstractArrayConverter(final Object defaultValue) {
152152
* @throws NullPointerException if <code>svalue</code>
153153
* is <code>null</code>
154154
*/
155-
protected List parseElements(String svalue) {
155+
protected List<String> parseElements(String svalue) {
156156

157157
// Validate the passed argument
158158
if (svalue == null) {

src/main/java/org/apache/commons/beanutils/converters/BooleanArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ public Object convert(final Class type, final Object value) {
216216
// sequence of values; see method AbstractArrayConverter.parseElements
217217
// for more information.
218218
try {
219-
final List list = parseElements(value.toString());
219+
final List<String> list = parseElements(value.toString());
220220
final boolean[] results = new boolean[list.size()];
221221
for (int i = 0; i < results.length; i++) {
222222
final String stringValue = (String) list.get(i);

src/main/java/org/apache/commons/beanutils/converters/ByteArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public Object convert(final Class type, final Object value) {
122122
// Parse the input value as a String into elements
123123
// and convert to the appropriate type
124124
try {
125-
final List list = parseElements(value.toString());
125+
final List<String> list = parseElements(value.toString());
126126
final byte[] results = new byte[list.size()];
127127
for (int i = 0; i < results.length; i++) {
128128
results[i] = Byte.parseByte((String) list.get(i));

src/main/java/org/apache/commons/beanutils/converters/CharacterArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public Object convert(final Class type, final Object value) {
122122
// Parse the input value as a String into elements
123123
// and convert to the appropriate type
124124
try {
125-
final List list = parseElements(value.toString());
125+
final List<String> list = parseElements(value.toString());
126126
final char[] results = new char[list.size()];
127127
for (int i = 0; i < results.length; i++) {
128128
results[i] = ((String) list.get(i)).charAt(0);

src/main/java/org/apache/commons/beanutils/converters/DoubleArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public Object convert(final Class type, final Object value) {
122122
// Parse the input value as a String into elements
123123
// and convert to the appropriate type
124124
try {
125-
final List list = parseElements(value.toString());
125+
final List<String> list = parseElements(value.toString());
126126
final double[] results = new double[list.size()];
127127
for (int i = 0; i < results.length; i++) {
128128
results[i] = Double.parseDouble((String) list.get(i));

src/main/java/org/apache/commons/beanutils/converters/FloatArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public Object convert(final Class type, final Object value) {
122122
// Parse the input value as a String into elements
123123
// and convert to the appropriate type
124124
try {
125-
final List list = parseElements(value.toString());
125+
final List<String> list = parseElements(value.toString());
126126
final float[] results = new float[list.size()];
127127
for (int i = 0; i < results.length; i++) {
128128
results[i] = Float.parseFloat((String) list.get(i));

src/main/java/org/apache/commons/beanutils/converters/IntegerArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public Object convert(final Class type, final Object value) {
122122
// Parse the input value as a String into elements
123123
// and convert to the appropriate type
124124
try {
125-
final List list = parseElements(value.toString());
125+
final List<String> list = parseElements(value.toString());
126126
final int[] results = new int[list.size()];
127127
for (int i = 0; i < results.length; i++) {
128128
results[i] = Integer.parseInt((String) list.get(i));

src/main/java/org/apache/commons/beanutils/converters/LongArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public Object convert(final Class type, final Object value) {
122122
// Parse the input value as a String into elements
123123
// and convert to the appropriate type
124124
try {
125-
final List list = parseElements(value.toString());
125+
final List<String> list = parseElements(value.toString());
126126
final long[] results = new long[list.size()];
127127
for (int i = 0; i < results.length; i++) {
128128
results[i] = Long.parseLong((String) list.get(i));

src/main/java/org/apache/commons/beanutils/converters/ShortArrayConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public Object convert(final Class type, final Object value) {
122122
// Parse the input value as a String into elements
123123
// and convert to the appropriate type
124124
try {
125-
final List list = parseElements(value.toString());
125+
final List<String> list = parseElements(value.toString());
126126
final short[] results = new short[list.size()];
127127
for (int i = 0; i < results.length; i++) {
128128
results[i] = Short.parseShort((String) list.get(i));

0 commit comments

Comments
 (0)