Don't initialize instance variables to their default values

Author: garydgregory

src/main/java/org/apache/commons/beanutils/ContextClassLoaderLocal.java

@@ -102,7 +102,7 @@
  */
 public class ContextClassLoaderLocal<T> {
     private final Map<ClassLoader, T> valueByClassLoader = new WeakHashMap<>();
-    private boolean globalValueInitialized = false;
+    private boolean globalValueInitialized;
     private T globalValue;
 
     /**

src/main/java/org/apache/commons/beanutils/LazyDynaClass.java

@@ -56,7 +56,7 @@ public class LazyDynaClass extends BasicDynaClass implements MutableDynaClass  {
      *
      * <p>Default is <code>false</code>.
      */
-    protected boolean returnNull = false;
+    protected boolean returnNull;
 
     /**
      * Construct a new LazyDynaClass with default parameters.

src/main/java/org/apache/commons/beanutils/LazyDynaMap.java

@@ -65,7 +65,7 @@ public class LazyDynaMap extends LazyDynaBean implements MutableDynaClass {
      *
      * <p>Default is <code>false</code>.
      */
-    protected boolean returnNull = false;
+    protected boolean returnNull;
 
     /**
      * Constructs a new instance.

src/main/java/org/apache/commons/beanutils/ResultSetIterator.java

@@ -34,7 +34,7 @@ public class ResultSetIterator implements DynaBean, Iterator<DynaBean> {
      * <p>Flag indicating whether the result set is currently positioned at a
      * row for which we have not yet returned an element in the iteration.</p>
      */
-    protected boolean current = false;
+    protected boolean current;
 
     /**
      * <p>The {@link ResultSetDynaClass} we are associated with.</p>
@@ -45,7 +45,7 @@ public class ResultSetIterator implements DynaBean, Iterator<DynaBean> {
      * <p>Flag indicating whether the result set has indicated that there are
      * no further rows.</p>
      */
-    protected boolean eof = false;
+    protected boolean eof;
 
     /**
      * <p>Construct an <code>Iterator</code> for the result set being wrapped

src/main/java/org/apache/commons/beanutils/converters/AbstractConverter.java

@@ -72,7 +72,7 @@ public abstract class AbstractConverter implements Converter {
     /**
      * Should we return the default value on conversion errors?
      */
-    private boolean useDefault = false;
+    private boolean useDefault;
 
     /**
      * The default value specified to our Constructor, if any.

src/main/java/org/apache/commons/beanutils/locale/BaseLocaleConverter.java

@@ -75,7 +75,7 @@ private static <T> T checkConversionResult(final Class<T> type, final Object res
     private Object defaultValue;
 
     /** Should we return the default value on conversion errors? */
-    protected boolean useDefault = false;
+    protected boolean useDefault;
 
     /** The locale specified to our Constructor, by default - system locale. */
     protected Locale locale = Locale.getDefault();
@@ -85,7 +85,7 @@ private static <T> T checkConversionResult(final Class<T> type, final Object res
 
 
     /** The flag indicating whether the given pattern string is localized or not. */
-    protected boolean locPattern = false;
+    protected boolean locPattern;
 
     /**
      * Create a {@link LocaleConverter} that will throw a {@link ConversionException}

src/main/java/org/apache/commons/beanutils/locale/LocaleConvertUtilsBean.java

@@ -182,7 +182,7 @@ public static LocaleConvertUtilsBean getInstance() {
     private Locale defaultLocale = Locale.getDefault();
 
     /** Indicate whether the pattern is localized or not */
-    private boolean applyLocalized = false;
+    private boolean applyLocalized;
 
     /** The <code>Log</code> instance for this class. */
     private final Log log = LogFactory.getLog(LocaleConvertUtils.class);

src/test/java/org/apache/commons/beanutils/NestedTestBean.java

@@ -34,7 +34,7 @@ public class NestedTestBean {
 
     private String testString = "NOT SET";
 
-    private boolean testBoolean = false;
+    private boolean testBoolean;
 
     private NestedTestBean indexedBeans[];
 

src/test/java/org/apache/commons/beanutils/TestBean.java

@@ -244,7 +244,7 @@ public static void incrementCounter(final Number amount) {
      * rules described in the JavaBeans Specification, this will be considered
      * a read-only boolean property, using isInvalidBoolean() as the getter.</p>
      */
-    private boolean invalidBoolean = false;
+    private boolean invalidBoolean;
 
     public TestBean() {
         listIndexed.add("String 0");