Use JUnit 5 convention for test method visibility

Author: garydgregory

src/test/java/org/apache/commons/beanutils2/BeanMapTest.java

@@ -267,7 +267,7 @@ protected Object putIfAbsent(final String key, final Object value) {
     }
 
     @Test
-    public void testBeanMapClone() {
+    void testBeanMapClone() {
         final BeanMap map = (BeanMap) makeFullMap();
         try {
             final BeanMap map2 = (BeanMap) map.clone();
@@ -284,7 +284,7 @@ public void testBeanMapClone() {
     }
 
     @Test
-    public void testBeanMapPutAllWriteable() {
+    void testBeanMapPutAllWriteable() {
         final BeanMap map1 = (BeanMap) makeFullMap();
         final BeanMap map2 = (BeanMap) makeFullMap();
         map2.put("someIntValue", Integer.valueOf(0));
@@ -296,7 +296,7 @@ public void testBeanMapPutAllWriteable() {
      * Test that the cause of exception thrown by clear() is initialized.
      */
     @Test
-    public void testExceptionThrowFromClear() {
+    void testExceptionThrowFromClear() {
         try {
             final Object bean = Jira87BeanFactory.createMappedPropertyBean();
             final BeanMap map = new BeanMap(bean);
@@ -318,7 +318,7 @@ public void testExceptionThrowFromClear() {
      * Test that the cause of exception thrown by a clone() is initialized.
      */
     @Test
-    public void testExceptionThrowFromClone() {
+    void testExceptionThrowFromClone() {
         // Test cloning a non-public bean (instantiation exception)
         try {
             final Object bean = Jira87BeanFactory.createMappedPropertyBean();
@@ -357,7 +357,7 @@ public void testExceptionThrowFromClone() {
      * Test that the cause of exception thrown by put() is initialized.
      */
     @Test
-    public void testExceptionThrowFromPut() {
+    void testExceptionThrowFromPut() {
         try {
             final Map<String, Object> map = new BeanMap(new BeanThrowingExceptions());
             map.put("valueThrowingException", "value");
@@ -382,7 +382,7 @@ public void testExceptionThrowFromPut() {
      * Test the default transformers using the getTypeTransformer() method
      */
     @Test
-    public void testGetTypeTransformerMethod() {
+    void testGetTypeTransformerMethod() {
         final BeanMap beanMap = new BeanMap();
         assertEquals(Boolean.TRUE, beanMap.getTypeTransformer(Boolean.TYPE).apply("true"), "Boolean.TYPE");
         assertEquals(Character.valueOf('B'), beanMap.getTypeTransformer(Character.TYPE).apply("BCD"), "Character.TYPE");
@@ -416,14 +416,14 @@ public void testMapPut() {
     }
 
     @Test
-    public void testMethodAccessor() throws Exception {
+    void testMethodAccessor() throws Exception {
         final BeanMap map = (BeanMap) makeFullMap();
         final Method method = BeanWithProperties.class.getDeclaredMethod("getSomeIntegerValue");
         assertEquals(method, map.getReadMethod("someIntegerValue"));
     }
 
     @Test
-    public void testMethodMutator() throws Exception {
+    void testMethodMutator() throws Exception {
         final BeanMap map = (BeanMap) makeFullMap();
         final Method method = BeanWithProperties.class.getDeclaredMethod("setSomeIntegerValue", Integer.class);
         assertEquals(method, map.getWriteMethod("someIntegerValue"));

src/test/java/org/apache/commons/beanutils2/ConvertUtilsTest.java

@@ -84,7 +84,7 @@ public void tearDown() {
     @Test
     @SuppressWarnings({ "unchecked", "rawtypes" })
     // We need to use raw types in order to test legacy converters
-    public void testConvertToString() throws Exception {
+    void testConvertToString() throws Exception {
         final Converter dummyConverter = (type, value) -> value;
 
         final Converter fooConverter = (type, value) -> "Foo-Converter";

src/test/java/org/apache/commons/beanutils2/LazyDynaListTest.java

@@ -268,7 +268,7 @@ public void tearDown() {
     /**
      * Test Collection
      */
-    public void testCollection(final LazyDynaList list, final Class<?> testClass, final DynaClass testDynaClass, final Object wrongBean) {
+    void testCollection(final LazyDynaList list, final Class<?> testClass, final DynaClass testDynaClass, final Object wrongBean) {
 
         // Create Collection & Array of Maps
         final int size = 5;

src/test/java/org/apache/commons/beanutils2/converters/CharacterConverterTest.java

@@ -74,7 +74,7 @@ void testConvertToCharacterNullNoDefault() {
      */
     @Test
     @SuppressWarnings("unchecked") // testing raw conversion
-    public void testConvertToString() {
+    void testConvertToString() {
 
         final Converter<Character> converter = new CharacterConverter();
         @SuppressWarnings("rawtypes")
@@ -91,7 +91,7 @@ public void testConvertToString() {
      */
     @Test
     @SuppressWarnings("unchecked") // tests failure so allow mismatch
-    public void testConvertToUnsupportedType() {
+    void testConvertToUnsupportedType() {
         @SuppressWarnings("rawtypes") // tests failure so allow mismatch
         final Converter converter = new CharacterConverter();
         assertThrows(ConversionException.class, () -> converter.convert(Integer.class, "Test"));

src/test/java/org/apache/commons/beanutils2/converters/IntegerConverterTest.java

@@ -93,7 +93,7 @@ void testInvalidAmount() {
      */
     @Test
     @SuppressWarnings("unchecked") // raw to test throwing
-    public void testInvalidDefaultObject() {
+    void testInvalidDefaultObject() {
         @SuppressWarnings("rawtypes") // raw to test throwing
         final NumberConverter converter = makeConverter();
         assertThrows(ConversionException.class, () -> converter.setDefaultValue("notANumber"), "Invalid default value not detected!");