[CLI-344] Option.processValue() throws NullPointerException when passed

null value with value separator configured

Fail faster with a more precise NullPointerException

Author: garydgregory

src/changes/changes.xml

@@ -35,7 +35,8 @@
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Remove -nouses directive from maven-bundle-plugin. OSGi package imports now state 'uses' definitions for package imports, this doesn't affect JPMS (from org.apache.commons:commons-parent:80).</action>
       <action type="fix" dev="ggregory" due-to="Arnout Engelen">Deprecate PatternOptionBuilder.PatternOptionBuilder().</action>
       <action type="fix" issue="CLI-341" dev="ggregory" due-to="Ruiqi Dong, Gary Gregory">HelpFormatter infinite loop with 0 width input.</action>
-      <action type="fix" issue="CLI-349" dev="ggregory" due-to="Leo Fernandes, Gary Gregory">DefaultParser.parse() throws NullPointerException when options parameter is null.</action>
+      <action type="fix" issue="CLI-349" dev="ggregory" due-to="Leo Fernandes, Gary Gregory">Fail faster with a more precise NullPointerException: Option.processValue() throws NullPointerException when passed null value with value separator configured.</action>
+      <action type="fix" issue="CLI-344" dev="ggregory" due-to="Ruiqi Dong, Gary Gregory">Fail faster with a more precise NullPointerException: DefaultParser.parse() throws NullPointerException when options parameter is null.</action>
       <!-- ADD -->
       <action type="add" issue="CLI-339" dev="ggregory" due-to="Claude Warren, Gary Gregory">Help formatter extension in the new package #314.</action>
       <action type="add" dev="ggregory" due-to="Gary Gregory">CommandLine.Builder implements Supplier&lt;CommandLine&gt;.</action>

src/main/java/org/apache/commons/cli/Option.java

@@ -830,7 +830,7 @@ void processValue(final String value) {
         if (argCount == UNINITIALIZED) {
             throw new IllegalArgumentException("NO_ARGS_ALLOWED");
         }
-        String add = value;
+        String add = Objects.requireNonNull(value, "value");
         // this Option has a separator character
         if (hasValueSeparator()) {
             // get the separator character

src/test/java/org/apache/commons/cli/OptionTest.java

@@ -300,6 +300,14 @@ void testHashCode() {
         assertNotEquals(Option.builder("test").build().hashCode(), Option.builder("test").longOpt("long test").build().hashCode());
     }
 
+    @Test
+    public void testProcessValue() {
+        final Option option = new Option("D", true, "Define property");
+        option.setValueSeparator('=');
+        final NullPointerException exception = assertThrows(NullPointerException.class, () -> option.processValue(null));
+        assertTrue(exception.getMessage().contains("value"));
+    }
+
     @Test
     void testSerialization() throws IOException, ClassNotFoundException {
         final Option option = Option.builder("o").type(TypeHandlerTest.Instantiable.class).build();