org.apache.commons.cli.Option.processValue(String) should throw

IllegalStateException instead of IllegalArgumentException

The method throws the exception if the state is wrong, not if the
argument is

Author: garydgregory

src/changes/changes.xml

@@ -39,6 +39,7 @@
       <action type="fix" issue="CLI-344" dev="ggregory" due-to="Ruiqi Dong, Gary Gregory">Fail faster with a more precise NullPointerException: DefaultParser.parse() throws NullPointerException when options parameter is null.</action>
       <action type="fix" issue="CLI-347" dev="ggregory" due-to="Ruiqi Dong, Gary Gregory">Options.addOptionGroup(OptionGroup) does not remove required options from requiredOpts list.</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">org.apache.commons.cli.Option.Builder.get() should throw IllegalStateException instead of IllegalArgumentException.</action>
+      <action type="fix" dev="ggregory" due-to="Gary Gregory">org.apache.commons.cli.Option.processValue(String) should throw IllegalStateException instead of IllegalArgumentException.</action>
       <!-- ADD -->
       <action type="add" issue="CLI-339" dev="ggregory" due-to="Claude Warren, Gary Gregory">Help formatter extension in the new package #314.</action>
       <action type="add" dev="ggregory" due-to="Gary Gregory">CommandLine.Builder implements Supplier&lt;CommandLine&gt;.</action>

src/main/java/org/apache/commons/cli/Option.java

@@ -840,7 +840,7 @@ public boolean isRequired() {
      */
     void processValue(final String value) {
         if (argCount == UNINITIALIZED) {
-            throw new IllegalArgumentException("NO_ARGS_ALLOWED");
+            throw new IllegalStateException("NO_ARGS_ALLOWED");
         }
         String add = Objects.requireNonNull(value, "value");
         // this Option has a separator character

src/test/java/org/apache/commons/cli/OptionTest.java

@@ -104,7 +104,7 @@ private Option roundTrip(final Option o) throws IOException, ClassNotFoundExcept
     void testAddValue() {
         final Option option = new Option("f", null);
         assertThrows(UnsupportedOperationException.class, () -> option.addValue(""));
-        assertThrows(IllegalArgumentException.class, () -> option.processValue(""));
+        assertThrows(IllegalStateException.class, () -> option.processValue(""));
     }
 
     @Test